Skip to content

Don't emit warning when encountering link with none #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LaurenzV merged 4 commits into from
Dec 21, 2025
Merged

Don't emit warning when encountering link with none #994

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
792f3d0
remove warning for marker
Its-Just-Nans Dec 21, 2025
838b839
fix
Its-Just-Nans Dec 21, 2025
9266491
fix: catch AId with none
Its-Just-Nans Dec 21, 2025
47bace7
typo
Its-Just-Nans Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions crates/usvg/src/parser/svgtree/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,23 @@ impl<'a, 'input: 'a> SvgNode<'a, 'input> {
.iter()
.find(|a| a.name == aid)
.map(|a| a.value.as_str())?;
// These AId have an initial value of none
let is_possible_none = matches!(
aid,
AId::Mask
| AId::MarkerStart
| AId::MarkerMid
| AId::MarkerEnd
| AId::ClipPath
| AId::Filter
| AId::FontSizeAdjust
| AId::TextDecoration
| AId::Stroke
| AId::StrokeDasharray
);
if is_possible_none && value == "none" {
return None;
}
match T::parse(*self, aid, value) {
Some(v) => Some(v),
None => {
Expand Down