parley: split TextStyle lifetimes for family vs settings #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `TextStyle` to take two lifetimes: one for `FontFamily` and one for OpenType settings (`FontVariations` / `FontFeatures`). This lets callers keep a long-lived font-family value while borrowing per-run settings without forcing both to share a single lifetime. Update internal APIs and tests to use `TextStyle<'_, '_, B>`.
Contributor
Author
|
This is split from #516 and should be more generally useful. |
Contributor
Author
|
If we do something to change the lifetime structure of the font family, then this might be less necessary. But that also isn't currently clear... |
taj-p
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
TextStyleto take two lifetimes: one forFontFamilyand one for OpenType settings (FontVariations/FontFeatures). This lets callers keep a long-lived font-family value while borrowing per-run settings without forcing both to share a single lifetime.Update internal APIs and tests to use
TextStyle<'_, '_, B>.