Report for snapshot testing (diff included)#185
Report for snapshot testing (diff included)#185spirali wants to merge 4 commits intolinebender:mainfrom
Conversation
|
Some thoughts:
|
|
521d855 to
88929a8
Compare
|
I have added |
|
Thank you! The new in-repository version looks really good. Would you mind opening a thread about image_diff_review in #linebender? I think that's probably the next steps here. The questions are:
My preference would be to nerd-snipe someone into writing a Xilem application, as that would have the greatest upside for us - it would allow us to validate the development of Xilem. But I do think the html version is still useful to have; I'll review again next week when we see what the outcome of that thread is. From a quick scan, it looks good. One thing I did notice is that this seems to add a dependency on |
|
Thanks. I will start the thread. Many dependencies comes from the "image" crate with default features, by default it is able to load various formats. |
|
Dependency tree was stripped down. |
|
I did some refactoring of xtask CLI and added detection of dead snapshots. |
|
The xtask is now migrated to Kompari. |
|
Replaced by #272 |
… detection) (#272) Adds command `cargo xtask` that allows to: ## Creating report ```bash cargo xtask report ``` creates HTML file with report containing snapshots that does not match ## Interactive test blessing: ```bash cargo xtask review ``` stars a local web server with the following page: (screenshot obtained by putting an artificial error into each snapshot test)  ## Detecting dead snapshots ```bash cargo xtask dead-snapshots ``` This PR fully replaces #185 --------- Co-authored-by: Tom Churchman <thomas@kepow.org>
This PR adds reporting to tests.
Originally I wanted to integrate reporting directly into the testing framework,
but at the end, I have create a separate tool https://github.com/spirali/image_diff_review
and put a simple script into the Parley repository.
The main reasons are:
Installation:
cargo install image_diff_reviewUsage:
If one or more tests fails, you may run
/parley/tests/make_report.shthat creates areport.htmlfilethat looks like this: