-
Notifications
You must be signed in to change notification settings - Fork 10
Use stronger wording in unpremultiplied interpolation changelog entry #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CHANGELOG.md
Outdated
|
|
||
| While such interpolation will often give perceptually undesired results, this allows using Color to implement rendering features where such interpolation is specified or desired, like in the [HTML Canvas element][]. ([#185][] by [@sagudev][]) | ||
|
|
||
| [HTML Canvas element]: https://html.spec.whatwg.org/commit-snapshots/a93c6fa9fa95e31f1caa05f2f8abc650669df7c3/#interpolation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our links are generally at the bottom of the changelog. Do we want that for this, too? In the extreme it could get somewhat confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think per-section links here makes sense.
I'd probably put it at the bottom of "Unreleased", rather than at the bottom of "Added", but that isn't based on any strong principles.
DJMcNab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
CHANGELOG.md
Outdated
|
|
||
| While such interpolation will often give perceptually undesired results, this allows using Color to implement rendering features where such interpolation is specified or desired, like in the [HTML Canvas element][]. ([#185][] by [@sagudev][]) | ||
|
|
||
| [HTML Canvas element]: https://html.spec.whatwg.org/commit-snapshots/a93c6fa9fa95e31f1caa05f2f8abc650669df7c3/#interpolation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think per-section links here makes sense.
I'd probably put it at the bottom of "Unreleased", rather than at the bottom of "Added", but that isn't based on any strong principles.
661dd5c to
099c16d
Compare
Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
No description provided.