First draft of Okhsv color space #131
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a mostly mechanical translation from the [reference implementation provided by Björn Ottosson](https://github.com/bottosson/bottosson.github.io/blob/f6f08b7fde9436be1f20f66cebbc739d660898fd/misc/ok_color.h). I've not done a deep dive into the math. This just differs by a few optimizations. Note: the conversion into and out of this color space are approximations due to `compute_max_srgb_saturation`. The other picker, `Okhsl`, would share most of this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly mechanical translation from the reference implementation provided by Björn Ottosson.
I've not done a deep dive into the math. This just differs by a few optimizations.
Note: the conversion into and out of this color space are approximations due to
compute_max_srgb_saturation. The other picker,Okhsl, would share most of this code.