feat: revamped homepage #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying validator-voting-ui with
|
| Latest commit: |
ec17c86
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f834644c.validator-voting-ui.pages.dev |
| Branch Preview URL: | https://feat-home-v2.validator-voting-ui.pages.dev |
linguists
requested changes
Jul 25, 2025
src/containers/vote/index.ts
Outdated
| setTotalVotedStakeAmount(Big(data[1])); | ||
| setVotedYeaStakeAmount(Big(data[0])); | ||
| setVotedStakeAmount(Big(data[1])); | ||
| setTotalVotedStakeAmount(Big(data[2])); |
Contributor
There was a problem hiding this comment.
This is the total stake amount, including what is not voted. I think totalStakeAmount will be more appropriate.
src/pages/details/index.tsx
Outdated
| const aVote = a.vote === 'yes' ? votes[a.accountId] || '0' : a.totalStakedBalance; | ||
| const bVote = b.vote === 'yes' ? votes[b.accountId] || '0' : b.totalStakedBalance; | ||
| const aVote = | ||
| a.vote === 'yes' |
Contributor
There was a problem hiding this comment.
For either yes or no vote, we can get the voted stake amount from votes[accountId][1] now, since contract tracks stake amount for both yes and no.
src/pages/home/index.tsx
Outdated
| const currentProgressPercent = passed | ||
| ? 100 | ||
| : Math.round((votedPercentNum / targetPercent) * 100); | ||
| // const totalProgressPercentText = passed ? votedPercentNum : targetPercent; |
Contributor
There was a problem hiding this comment.
Do we need to remove the comment?
src/pages/home/index.tsx
Outdated
| {targetPercent}%{targetBadge} | ||
| <div className="flex w-0.5 left-1/2 h-[24px] -top-[32px] -translate-x-1/2 bg-[hsla(0,0%,12%,0.08)] absolute"></div> | ||
| </div> | ||
| {/* <div className="absolute" style={{ right: '0' }}> |
Contributor
There was a problem hiding this comment.
Do we need to remove the comment?
linguists
reviewed
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.