Skip to content

fix: Highlight "Sharings" section on shared folders#3795

Open
doubleface wants to merge 1 commit intomasterfrom
fix/shareddriveHighlightInNav
Open

fix: Highlight "Sharings" section on shared folders#3795
doubleface wants to merge 1 commit intomasterfrom
fix/shareddriveHighlightInNav

Conversation

@doubleface
Copy link
Copy Markdown
Contributor

@doubleface doubleface commented Apr 9, 2026

even when reloading the page

Summary by CodeRabbit

  • Bug Fixes
    • Navigation item for shared content now correctly highlights when accessing both shared folders and shared drives, improving menu consistency.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 97ed2bc6-78b4-43a4-8166-920436719a77

📥 Commits

Reviewing files that changed from the base of the PR and between 69fe7bc and 6750d07.

📒 Files selected for processing (1)
  • src/modules/navigation/SharingsNavItem.jsx

Walkthrough

The SharingsNavItem component's route-matching regular expression was updated to match both /sharings and /sharedrive paths (each with optional subpaths), replacing the previous pattern that only matched /sharings. The component's signature, exports, and control flow remain unchanged. This is a minimal modification affecting a single line of code.

Suggested reviewers

  • JF-Cozy
  • rezk2ll
  • zatteo
  • lethemanh
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: updating the navigation highlight to work with shared folders, which matches the modification to the route-matching regex.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/shareddriveHighlightInNav

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@bundlemon
Copy link
Copy Markdown

bundlemon bot commented Apr 9, 2026

BundleMon

Files updated (1)
Status Path Size Limits
static/js/main.(hash).js
168.16KB (+12B +0.01%) -
Unchanged files (20)
Status Path Size Limits
static/js/(chunkId).(hash).js
1.17MB -
public/static/js/(chunkId).(hash).js
1.1MB -
static/js/cozy.(hash).js
919.45KB -
public/static/js/cozy.(hash).js
782.19KB -
(hash).js
336.11KB -
public/(hash).js
336.11KB -
services/qualificationMigration.js
283.13KB -
services/dacc.js
262.86KB -
public/static/js/public.(hash).js
141.72KB -
public/static/js/lib-react.(hash).js
43.88KB -
static/js/lib-react.(hash).js
43.88KB -
public/static/css/cozy.(hash).css
31.56KB -
static/css/cozy.(hash).css
31.56KB -
public/static/js/lib-router.(hash).js
21.86KB -
static/js/lib-router.(hash).js
21.86KB -
static/css/main.(hash).css
17.04KB -
public/static/css/public.(hash).css
6.76KB -
manifest.webapp
3.04KB -
index.html
700B -
assets/manifest.json
185B -

Total files change +8B 0%

Groups updated (1)
Status Path Size Limits
**/*.js
7.61MB (+12B 0%) -
Unchanged groups (2)
Status Path Size Limits
**/*.{png,svg,ico}
2.19MB -
**/*.css
120.14KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant