Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis PR updates runtime dependency versions in package.json, exposes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
doubleface
force-pushed
the
feat/update-cozy-ui-138
branch
from
83fb157 to
9ff2a54
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
doubleface
requested review from
JF-Cozy,
doubleface,
lethemanh and
rezk2ll
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
src/modules/filelist/icons/FileThumbnail.tsx (1)
170-212: Extract repeated badge wrapper UI into a reusable class/component.Lines 173-183 and Line 195-207 duplicate inline wrapper rendering/styling. Centralizing this will reduce drift and simplify future theme adjustments.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/modules/filelist/icons/FileThumbnail.tsx` around lines 170 - 212, The Badge wrapper markup for the small rounded icon (used around Icon/LinkIcon at the first Badge badgeContent) and the sharing badge (used around SharingShortcutIcon and SharingOwnerAvatar) duplicates inline wrapper div styles; create a small reusable presentational component or CSS class (e.g., FileThumbnailBadge or .file-thumbnail-badge) and replace the inline divs in the Badge badgeContent blocks, moving shared styles (padding, sizing, backgroundColor, color, boxShadow/border, borderRadius, flex centering) into that component/class and use it for both occurrences so Badge (and consumers like Icon, LinkIcon, SharingShortcutIcon, SharingOwnerAvatar, fileIcon) render consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/ColorPicker/ColorPicker.jsx`:
- Around line 42-47: The Avatar instances in ColorPicker.jsx are using a
non-existent backgroundColor prop so the background stays as the hardcoded color
prop; replace the backgroundColor prop with the color prop on both Avatar usages
so the component uses the dynamic values (e.g., change the Avatar that should
use the paper background to color="var(--papeBackgroundColor)" and change the
swatch Avatar inside the COLORS mapping to color={color}); update the two Avatar
prop names accordingly (refer to the Avatar component and the COLORS
array/swatches in the ColorPicker component).
In `@src/components/pushClient/Banner.jsx`:
- Around line 83-91: The anchor rendered in Banner.jsx that uses component="a"
with target="_blank" (the element with props label={t('Nav.banner-btn-client')},
onClick={() => this.markAsSeen('banner')}, startIcon={<Icon icon={DownloadIcon}
/>}, href={link}) must include rel="noopener noreferrer"; update that JSX
element to add the rel prop to prevent reverse-tabnabbing while preserving
existing props and behavior.
In `@src/modules/filelist/virtualized/cells/SharingShortcutBadge.jsx`:
- Around line 13-18: The Avatar component in SharingShortcutBadge.jsx
accidentally receives a stray boolean prop "Avatar" (the token "Avatar" on the
opening <Avatar ...> tag) which should be removed; locate the Avatar JSX element
in the SharingShortcutBadge functional component and delete the lone "Avatar"
attribute so the component only has valid props (e.g., color, textColor, size)
passed.
---
Nitpick comments:
In `@src/modules/filelist/icons/FileThumbnail.tsx`:
- Around line 170-212: The Badge wrapper markup for the small rounded icon (used
around Icon/LinkIcon at the first Badge badgeContent) and the sharing badge
(used around SharingShortcutIcon and SharingOwnerAvatar) duplicates inline
wrapper div styles; create a small reusable presentational component or CSS
class (e.g., FileThumbnailBadge or .file-thumbnail-badge) and replace the inline
divs in the Badge badgeContent blocks, moving shared styles (padding, sizing,
backgroundColor, color, boxShadow/border, borderRadius, flex centering) into
that component/class and use it for both occurrences so Badge (and consumers
like Icon, LinkIcon, SharingShortcutIcon, SharingOwnerAvatar, fileIcon) render
consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4bbde1e9-c551-4133-86c4-218463fa90e1
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (14)
jestHelpers/setup.jspackage.jsonsrc/components/ColorPicker/ColorPicker.jsxsrc/components/FolderPicker/FolderPickerHeader.tsxsrc/components/FolderPicker/FolderPickerHeaderIllustration.tsxsrc/components/PushBanner/QuotaBanner.jsxsrc/components/pushClient/Banner.jsxsrc/modules/filelist/File.jsxsrc/modules/filelist/cells/SharingShortcutBadge.jsxsrc/modules/filelist/icons/FileThumbnail.tsxsrc/modules/filelist/virtualized/GridFile.jsxsrc/modules/filelist/virtualized/cells/SharingShortcutBadge.jsxsrc/modules/navigation/NavContent.tsxsrc/store/rootReducer.js
💤 Files with no reviewable changes (1)
- src/store/rootReducer.js
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
BundleMonFiles updated (8)
Unchanged files (13)
Total files change +244.62KB +4.42% Groups updated (2)
Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
doubleface
force-pushed
the
feat/update-cozy-ui-138
branch
from
f4f1fb3 to
2a6b7c2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The Alert component from cozy-ui accepts `action` (singular), not `actions`. The wrong prop name caused buttons to be passed as an HTML attribute and never rendered.
cozy-bar (via cozy-search -> @assistant-ui/react -> assistant-stream)
uses the Fetch API `Response` class at module level, which is not
available in the jsdom test environment.
Mocking cozy-search breaks the import chain before the problematic
code is reached, fixing the suites that called
jest.requireActual('cozy-bar').
…rnings cozy-bar's BarRoutes.js calls React.createElement with AssistantDialog and SearchDialog from cozy-search at module load time. Mocking cozy-search with an empty object caused React to log an invalid-type warning before any test ran, triggering the ConsoleUsageReporter.
doubleface
force-pushed
the
feat/update-cozy-ui-138
branch
from
2a6b7c2 to
527a3e9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/pushClient/Banner.jsx (1)
87-97: Remove unused callback arguments for clarity.At Line 87 and Line 97,
markAsSeenis called with arguments that are never consumed. This is harmless but noisy.♻️ Suggested cleanup
- onClick={() => this.markAsSeen('banner')} + onClick={() => this.markAsSeen()} ... - onClick={() => this.markAsSeen('close')} + onClick={() => this.markAsSeen()}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/pushClient/Banner.jsx` around lines 87 - 97, The onClick handlers in Banner.jsx call markAsSeen with unused arguments ('banner' and 'close'); remove those unnecessary args to clean up the code by changing the onClick callbacks to call this.markAsSeen() instead (update both occurrences where markAsSeen is referenced in the Button and the other clickable element to use no arguments).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/modules/filelist/virtualized/cells/SharingShortcutBadge.jsx`:
- Around line 13-17: Prettier is failing because the Avatar JSX props in
SharingShortcutBadge.jsx are split across multiple lines; update the Avatar
element (the Avatar component instance) so its props are on a single line (e.g.,
combine color, textColor, and size into one line) to satisfy the
prettier/prettier rule and re-run CI.
---
Nitpick comments:
In `@src/components/pushClient/Banner.jsx`:
- Around line 87-97: The onClick handlers in Banner.jsx call markAsSeen with
unused arguments ('banner' and 'close'); remove those unnecessary args to clean
up the code by changing the onClick callbacks to call this.markAsSeen() instead
(update both occurrences where markAsSeen is referenced in the Button and the
other clickable element to use no arguments).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e2ca9ef9-1507-4cc1-bf99-6aa1e45027c7
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (14)
jestHelpers/setup.jspackage.jsonsrc/components/ColorPicker/ColorPicker.jsxsrc/components/FolderPicker/FolderPickerHeader.tsxsrc/components/FolderPicker/FolderPickerHeaderIllustration.tsxsrc/components/PushBanner/QuotaBanner.jsxsrc/components/pushClient/Banner.jsxsrc/modules/filelist/File.jsxsrc/modules/filelist/cells/SharingShortcutBadge.jsxsrc/modules/filelist/icons/FileThumbnail.tsxsrc/modules/filelist/virtualized/GridFile.jsxsrc/modules/filelist/virtualized/cells/SharingShortcutBadge.jsxsrc/modules/navigation/NavContent.tsxsrc/store/rootReducer.js
💤 Files with no reviewable changes (1)
- src/store/rootReducer.js
✅ Files skipped from review due to trivial changes (7)
- src/modules/filelist/cells/SharingShortcutBadge.jsx
- src/modules/filelist/virtualized/GridFile.jsx
- src/modules/filelist/File.jsx
- src/modules/filelist/icons/FileThumbnail.tsx
- src/components/FolderPicker/FolderPickerHeader.tsx
- package.json
- src/components/PushBanner/QuotaBanner.jsx
🚧 Files skipped from review as they are similar to previous changes (3)
- jestHelpers/setup.js
- src/components/FolderPicker/FolderPickerHeaderIllustration.tsx
- src/components/ColorPicker/ColorPicker.jsx
There was a problem hiding this comment.
Gates Passed
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/pushClient/Banner.jsx (1)
50-53: Unused parameters passed tomarkAsSeen.The
markAsSeen()method takes no parameters, but it's called with'banner'and'close'string arguments on lines 87 and 97. These values are silently ignored. If the distinction was intended for analytics or debugging, consider using the parameter; otherwise, remove the arguments for clarity.♻️ Suggested fix (if distinction not needed)
- onClick={() => this.markAsSeen('banner')} + onClick={() => this.markAsSeen()}- onClick={() => this.markAsSeen('close')} + onClick={() => this.markAsSeen()}Also applies to: 87-87, 97-97
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/pushClient/Banner.jsx` around lines 50 - 53, The markAsSeen method currently ignores any arguments which leads to misleading calls; either remove the unused string args where markAsSeen(...) is invoked or update markAsSeen to accept and use a parameter for analytics; specifically, for a simple clarity fix remove the `'banner'` and `'close'` arguments from the calls and keep markAsSeen() as defined (which sets DESKTOP_BANNER via localforage and this.setState({ mustShow: false })), or if you need the distinction, change markAsSeen to markAsSeen(reason) and record/use the reason (e.g., send to analytics or include in a log) while preserving the localforage setItem and state update.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/components/pushClient/Banner.jsx`:
- Around line 50-53: The markAsSeen method currently ignores any arguments which
leads to misleading calls; either remove the unused string args where
markAsSeen(...) is invoked or update markAsSeen to accept and use a parameter
for analytics; specifically, for a simple clarity fix remove the `'banner'` and
`'close'` arguments from the calls and keep markAsSeen() as defined (which sets
DESKTOP_BANNER via localforage and this.setState({ mustShow: false })), or if
you need the distinction, change markAsSeen to markAsSeen(reason) and record/use
the reason (e.g., send to analytics or include in a log) while preserving the
localforage setItem and state update.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6752ad88-b134-44c8-aa39-14586ce2f8cb
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (14)
jestHelpers/setup.jspackage.jsonsrc/components/ColorPicker/ColorPicker.jsxsrc/components/FolderPicker/FolderPickerHeader.tsxsrc/components/FolderPicker/FolderPickerHeaderIllustration.tsxsrc/components/PushBanner/QuotaBanner.jsxsrc/components/pushClient/Banner.jsxsrc/modules/filelist/File.jsxsrc/modules/filelist/cells/SharingShortcutBadge.jsxsrc/modules/filelist/icons/FileThumbnail.tsxsrc/modules/filelist/virtualized/GridFile.jsxsrc/modules/filelist/virtualized/cells/SharingShortcutBadge.jsxsrc/modules/navigation/NavContent.tsxsrc/store/rootReducer.js
💤 Files with no reviewable changes (1)
- src/store/rootReducer.js
✅ Files skipped from review due to trivial changes (7)
- src/modules/filelist/virtualized/cells/SharingShortcutBadge.jsx
- src/modules/filelist/virtualized/GridFile.jsx
- src/modules/filelist/cells/SharingShortcutBadge.jsx
- src/modules/filelist/File.jsx
- package.json
- src/components/FolderPicker/FolderPickerHeader.tsx
- src/modules/filelist/icons/FileThumbnail.tsx
🚧 Files skipped from review as they are similar to previous changes (4)
- jestHelpers/setup.js
- src/components/FolderPicker/FolderPickerHeaderIllustration.tsx
- src/modules/navigation/NavContent.tsx
- src/components/PushBanner/QuotaBanner.jsx
doubleface
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Style