Use browser language for public sharing links instead of owner's locale#3774
Merged
Use browser language for public sharing links instead of owner's locale#3774
Conversation
Copilot
AI
changed the title
[WIP] Fix public link language setting for sharing
Use browser language for public sharing links instead of owner's locale
Mar 31, 2026
Crash--
approved these changes
Apr 7, 2026
c776f2d to
ab02f80
Compare
Contributor
|
@copilot can you squash the commits please |
Author
Squashing these commits requires a force-push to rewrite the branch history, which isn't available through the tools I have access to. You can squash them locally with |
Contributor
|
@copilot fix the linter issue please |
Author
lethemanh
reviewed
Apr 7, 2026
2ab715a to
d64532e
Compare
BundleMonFiles updated (1)
Unchanged files (20)
Total files change +85B 0% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
7824e76 to
ee3689f
Compare
Anonymous visitors on public sharing links were seeing the file owner's language instead of their own. Use the browser locale for unauthenticated visitors while keeping the instance locale for authenticated owners and older cozy-stack versions without the isLoggedIn flag. Co-authored-by: Quentin Valmori <1107936+crash--@users.noreply.github.com> Co-authored-by: lethemanh <16944047+lethemanh@users.noreply.github.com>
ee3689f to
704e105
Compare
There was a problem hiding this comment.
Gates Passed
3 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
rezk2ll
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataset.isLoggedIn(from cozy-stack PR #4719) to distinguish authenticated users from anonymous share visitorsdataset.isLoggedInis absent (older stack), fall back todataset.locale(previous behaviour) instead of the browser localedemo
drive-language.mp4