Conversation
rezk2ll
requested review from
JF-Cozy,
doubleface,
lethemanh and
zatteo
as code owners
Walkthroughpackage.json dependency entries were updated: multiple packages had their versions changed from fixed pins to caret ranges and several package names/keys were adjusted (examples: Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Line 110: Update the dependency to filesize v11 and verify runtime
compatibility by running the full test suite and manually checking the four
usages of filesize() (search for the symbol filesize() in the codebase) to
ensure they pass and still pass the explicit option { base: 10 } and expect
string output; also confirm ESM import style remains correct for v11 and no code
changes are required, but if any test fails, adjust the specific call sites of
filesize() to explicitly pass { base: 10 } or coerce to string as needed.
BundleMonFiles updated (9)
Unchanged files (12)
Total files change -46.43KB -0.88% Groups updated (2)
Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Line 74: The dependency "npm-run-all2"@^8.0.4 requires Node.js >=20; update
project config to reflect that and ensure all environments use Node 20+.
Specifically, add or update the package.json "engines" field to ">=20", update
CI workflow files (e.g., GitHub Actions node-version settings) to use node:20 or
later, and update any Dockerfiles or development container images to a Node 20
base image; also run CI locally or in a staging branch to validate scripts that
use npm-run-all2 (e.g., scripts invoking --parallel / run-p) still work.
♻️ Duplicate comments (1)
package.json (1)
110-110: filesize v11 migration already reviewed.The previous review comment adequately covers the breaking changes for this major version bump. Ensure the test suite validates file size formatting as recommended.
|
rsbuild >= 1.5 has not been tested on our side so we need to watch if something changes with the build (for example, when updating to 1.3 we lost auto reload when node_modules cozy packages were updated with rlink). |
i checked we have auto reload with extra warnings: |
2 participants
Issue
When running
yarn audit, we get342vulnerabilities (44 Low, 95 Moderate, 144 High, 59 Critical)Upgrades completed
@cozy Packages Upgraded (12 packages):
@cozy DevDependencies Upgraded (5 packages):
Other DevDependencies Upgraded (5 packages):
Runtime Dependencies Upgraded (5 packages):
Security Improvements
Vulnerabilities Reduced: 342 → 74 (78% reduction)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.