feat: Shell integration with external bridge container apps#3644
Draft
ecnivtwelve wants to merge 18 commits intomasterfrom
Draft
feat: Shell integration with external bridge container apps#3644ecnivtwelve wants to merge 18 commits intomasterfrom
ecnivtwelve wants to merge 18 commits intomasterfrom
Conversation
…SelectionProvider ♻️
ecnivtwelve
requested review from
JF-Cozy,
doubleface,
lethemanh,
rezk2ll and
zatteo
as code owners
BundleMonFiles updated (2)
Unchanged files (19)
Total files change +739B +0.01% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
Crash--
reviewed
Dec 1, 2025
|
|
||
| useEffect(() => { | ||
| if (window.top) { | ||
| window.top.postMessage('loaded', '*') |
Contributor
There was a problem hiding this comment.
who is the window.top here?
| style.type = 'text/css' | ||
| style.appendChild(document.createTextNode(CSS)) | ||
| document.head.appendChild(style) | ||
| } |
Contributor
There was a problem hiding this comment.
It should be done by a new entry / target.
| const openFileInParent = (file: File): void => { | ||
| if ('metadata' in file && window.top) { | ||
| const id = file.metadata.externalId || '' | ||
| window.top.postMessage('openFile:' + id, '*') |
Contributor
There was a problem hiding this comment.
Who is listening / definning this openFile ?
Contributor
|
In my opinion we'll always block iframe on Drive. So maybe we should use something like intent to do it properly even if I'm not a big fan of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Shell containers (such as LaSuite Docs) can call controller apps (that runs inside them) to serve as a pilot to the embedded app.
Note
LaSuite Docs needs cozy/cozy-lasuite-docs#6 to be compatible with this PR
Changes
Drive (running inside an iframe) can be used as a file manager, will be able to :