fix: Display correct right click menu in file viewer 🐛

[lethemanh]

Change:

In file viewer, we need to display RightClickFileMenu instead of RightClickAddMenu.

Results:

Normal file viewer:

Shared drive file viewer:

[bundlemon]

BundleMon

Files updated (2)

Status	Path	Size	Limits
✅	static/js/main.(hash).js	156.93KB (+315B +0.2%)	-
✅	public/static/js/public.(hash).js	124.02KB (+124B +0.1%)	-

Unchanged files (19)

Status	Path	Size	Limits
✅	static/js/(chunkId).(hash).js	971.02KB	-
✅	static/js/cozy.(hash).js	906.65KB	-
✅	public/static/js/(chunkId).(hash).js	905.5KB	-
✅	public/static/js/cozy.(hash).js	771.96KB	-
✅	(hash).js	336.11KB	-
✅	public/(hash).js	336.11KB	-
✅	services/qualificationMigration.js	281.49KB	-
✅	services/dacc.js	261.47KB	-
✅	public/static/js/lib-react.(hash).js	39.24KB	-
✅	static/js/lib-react.(hash).js	39.24KB	-
✅	public/static/css/cozy.(hash).css	33.65KB	-
✅	static/css/cozy.(hash).css	33.65KB	-
✅	public/static/js/lib-router.(hash).js	21.86KB	-
✅	static/js/lib-router.(hash).js	21.86KB	-
✅	static/css/main.(hash).css	17.01KB	-
✅	public/static/css/public.(hash).css	6.7KB	-
✅	manifest.webapp	3.04KB	-
✅	index.html	691B	-
✅	assets/manifest.json	185B	-

Total files change +439B +0.01%

Groups updated (1)

Status	Path	Size	Limits
✅	**/*.js	6.92MB (+439B +0.01%)	-

Unchanged groups (2)

Status	Path	Size	Limits
✅	**/*.{png,svg,ico}	2.19MB	-
✅	**/*.css	127.85KB	-

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[rezk2ll]

i liked the displayInContextMenu solution to handle displaying the action in context menu and top bar.

however this function needs a little refactoring,

• the name is off, it suggest it does some converting or mutation, instead it's just a filter. you can rename it to getContextMenuActions
• L33 check is weird, you can just check the explicit value: !== false
• missing JSDoc
• add unit tests for this helper

you can make it more clean like this:

/**
 * Returns the context menu visible actions
 * 
 * @param {Object[]} actions - the list of actions
 * @returns {Object[]} - the list of actions to be displayed
 */
export const getContextMenuActions = (actions = []) =>
  actions.filter(action =>
    Object.values(action)[0]?.displayInContextMenu !== false
  )