feat: Update manifest to add acceptFromFlagship#2967
Closed
Conversation
BundleMonFiles updated (5)
Unchanged files (14)
Total files change +1.04KB +0.02% Groups updated (4)
Unchanged groups (4)
Final result: ✅ View report in BundleMon website ➡️ |
Crash--
reviewed
Aug 21, 2023
| @@ -0,0 +1,13 @@ | |||
| import React from 'react' | |||
Contributor
There was a problem hiding this comment.
should be more in upload than Create.
Contributor
Author
There was a problem hiding this comment.
updated, will replace
{__TARGET__ === 'mobile' && (
<Route path="uploadfrommobile" element={<UploadFromMobile />} />
)}in subsequent pull request
Crash--
reviewed
Aug 21, 2023
src/drive/targets/manifest.webapp
Outdated
| }, | ||
| "accept_from_flagship": true, | ||
| "accept_documents_from_flagship": { | ||
| "accepted_mime_types": ["application/octet-stream"], |
Contributor
There was a problem hiding this comment.
this will not be the only accepted mime. In fact, with Drive, you can go with : [*].
Contributor
Author
There was a problem hiding this comment.
Updated with "/" according to https://www.rfc-editor.org/rfc/rfc7231#section-5.3.2
acezard
force-pushed
the
feat--Update-manifest-to-add-acceptFromFlagship
branch
from
f349088 to
d2d953b
Compare
- Also add placeholder route that will handle mobile uploads later
acezard
force-pushed
the
feat--Update-manifest-to-add-acceptFromFlagship
branch
from
d2d953b to
3d7cc16
Compare
Contributor
Author
|
closing this pull request as it is now redundant with #2969 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Features
Update manifest to add acceptFromFlagship
Also add placeholder route that will handle mobile uploads later