Skip to content

TF-4229 Add a new field in search #4230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dab246 wants to merge 5 commits into
base: features/label
Choose a base branch
from
Open

TF-4229 Add a new field in search #4230

dab246 wants to merge 5 commits into from
+823 −149

Conversation

@dab246
Copy link
Member

@dab246 dab246 commented Jan 2, 2026 •
edited
Loading

Issue

#4229

Resolved

  • Web:
Screen.Recording.2026-01-02.at.18.03.07.mov
  • Mobile:
demo-mobile.webm

@coderabbitai
Copy link

coderabbitai bot commented Jan 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dab246 dab246 added the Label label Jan 2, 2026
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

This PR has been deployed to https://linagora.github.io/tmail-flutter/4230.

chibenwa
chibenwa reviewed Jan 5, 2026
View reviewed changes
lib/features/mailbox_dashboard/presentation/widgets/advanced_search/label_drop_down_button.dart Outdated
children: [
SvgPicture.asset(
isSelected
? imagePaths.icCheckboxSelected
Copy link
Member

@chibenwa chibenwa Jan 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I counted 11 levels of indentation which is far too much for sanity.

I recommend playing around with variable / method extraction and see if we can cut this beast in a way that makes sense.

I personnally think each sub-component deserve to be extracted in a standalone method.

Copy link
Member Author

@dab246 dab246 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@dab246 dab246 requested a review from chibenwa January 6, 2026 01:56
@dab246 dab246 force-pushed the features/tf-4229-add-a-new-field-in-search branch from 60db802 to 65e8302 Compare January 7, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoangdat hoangdat Awaiting requested review from hoangdat

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora

@chibenwa chibenwa Awaiting requested review from chibenwa

Assignees

No one assigned

Labels

Label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dab246 @chibenwa