Skip to content

refactor: Assistant flags#2356

Merged
paultranvan merged 1 commit intomasterfrom
rename-assistant-flags
Mar 24, 2026
Merged

refactor: Assistant flags#2356
paultranvan merged 1 commit intomasterfrom
rename-assistant-flags

Conversation

@paultranvan
Copy link
Copy Markdown
Contributor

@paultranvan paultranvan commented Mar 23, 2026

Now all assistant-related flags are prefixed with cozy.assistant.*. Also, we remove the cozy.assistant.top-bar.enabled, so we always have the top-bar

Summary by CodeRabbit

  • New Features

    • The new assistant view is now enabled by default and always shown for assistant routes.
  • Chores

    • Updated a package dependency to a newer patch version.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 331fb9b4-ead8-4aba-b1b6-63b92b8aec45

📥 Commits

Reviewing files that changed from the base of the PR and between 1a2984a and bc30864.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json
  • src/containers/App.jsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • package.json
  • src/containers/App.jsx

Walkthrough

Updated package.json to bump the cozy-search dependency from ^0.23.0 to ^0.23.3. In src/containers/App.jsx removed feature-flag gating for the new assistant view (cozy.top-bar-in-assistant.enabled); isNewAssistantView now derives solely from pathname.startsWith('/connected/assistant/'). The /connected/assistant/:conversationId route always renders AssistantView and the AssistantDialog import/gating logic was removed.

Possibly related PRs

Suggested reviewers

  • doubleface
  • rezk2ll
  • JF-Cozy
  • zatteo
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'refactor: Assistant flags' directly relates to the main change of removing feature-flag gating for the assistant view and updating dependencies, aligning with the PR objectives of renaming and removing assistant-related flags.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rename-assistant-flags

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bundlemon
Copy link
Copy Markdown

bundlemon bot commented Mar 23, 2026

BundleMon

Files updated (2)
Status Path Size Limits
static/js/main.(hash).js
82.45KB (-28B -0.03%) -
static/js/cozy.(hash).js
891.62KB (-349B -0.04%) -
Unchanged files (14)
Status Path Size Limits
static/js/(chunkId).(hash).js
1.08MB -
services/softDeleteOrRestoreAccounts.js
472.84KB -
services/updateAccounts.js
471.64KB -
services/deleteAccounts.js
321.18KB -
services/sourceAccountIdentifierNormalizer.js
260.34KB -
services/cliskTimeout.js
259.79KB -
services/sourceAccountIdentifierNormalizerHel
per.js
236.97KB -
services/myselfFromIdenties.js
236.78KB -
services/polyfillFetch.js
97.16KB -
static/js/lib-react.(hash).js
43.88KB -
static/css/cozy.(hash).css
32.33KB -
static/js/lib-router.(hash).js
26.7KB -
services/attributesHelpers.js
15.7KB -
static/css/main.(hash).css
8.77KB -

Total files change -377B -0.01%

Groups updated (1)
Status Path Size Limits
**/*.js
7.26MB (-377B 0%) -
Unchanged groups (2)
Status Path Size Limits
**/*.{png,svg,ico}
272.78KB -
**/*.css
88.07KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/containers/App.jsx (1)

18-18: Remove the unused AssistantDialog jest mock.

AssistantDialog is no longer imported in src/containers/App.jsx and has no remaining references in the codebase. The mock definition in test/jestLib/setup.js (line 32) is dead code and should be removed to keep the test setup clean.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/containers/App.jsx` at line 18, Remove the dead Jest mock for
AssistantDialog from the test setup: locate the mock declaration for
AssistantDialog in the Jest setup file and delete it so tests no longer include
an unused mock; ensure no other code references the symbol AssistantDialog and
run the test suite to confirm no missing mocks or imports remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/containers/App.jsx`:
- Line 18: Remove the dead Jest mock for AssistantDialog from the test setup:
locate the mock declaration for AssistantDialog in the Jest setup file and
delete it so tests no longer include an unused mock; ensure no other code
references the symbol AssistantDialog and run the test suite to confirm no
missing mocks or imports remain.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ae7dc12-8e27-4f7c-9987-a12bd5afaa6d

📥 Commits

Reviewing files that changed from the base of the PR and between 5f6aa64 and 1a2984a.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json
  • src/containers/App.jsx

Now all assistant-related flags are prefixed with `cozy.assistant.*`.
Also, we remove the cozy.assistant.top-bar.enabled, so we always have
the top-bar
@paultranvan paultranvan force-pushed the rename-assistant-flags branch from 1a2984a to bc30864 Compare March 24, 2026 08:41
@paultranvan paultranvan merged commit 8775a3a into master Mar 24, 2026
5 checks passed
@paultranvan paultranvan deleted the rename-assistant-flags branch March 24, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants