Skip to content

POC: Reduce loading of app due to crypto feature#1291

Draft
zatteo wants to merge 3 commits intomasterfrom
feat/improve-crypto
Draft

POC: Reduce loading of app due to crypto feature#1291
zatteo wants to merge 3 commits intomasterfrom
feat/improve-crypto

Conversation

@zatteo
Copy link
Copy Markdown
Member

@zatteo zatteo commented Feb 10, 2025

  • Use react-native-quick-crypto when possible
  • Delay CryptoWebview loading (getClient and useAppBootstrap can start before CryptoWebview loading)

Todo

  • check if it is the delay is not too long
  • check on iOS
  • check on Android

@zatteo zatteo changed the base branch from master to feat/meta_offline February 10, 2025 15:13
Base automatically changed from feat/meta_offline to master February 12, 2025 10:03
@zatteo zatteo force-pushed the feat/improve-crypto branch from c4e24c6 to a0364c1 Compare March 7, 2025 09:25
@Crash--
Copy link
Copy Markdown
Contributor

Crash-- commented Nov 4, 2025

Since we open signup now to login / register, we can remove this cryptowebview, right?

@zatteo
Copy link
Copy Markdown
Member Author

zatteo commented Nov 4, 2025

Since we open signup now to login / register, we can remove this cryptowebview, right?

Interesting, at least we do not need to open it at startup. It still used after but it can helps the loading time 👍

@Crash--
Copy link
Copy Markdown
Contributor

Crash-- commented Nov 4, 2025

Why do we still need it? I can't remember

@zatteo
Copy link
Copy Markdown
Member Author

zatteo commented Nov 4, 2025

Why do we still need it? I can't remember

To polyfill crypto API in WebView in iOS if I remember well?

@Crash--
Copy link
Copy Markdown
Contributor

Crash-- commented Nov 6, 2025

Yeah but when do we need this crypto api anymore since we don't have Registration / Login?

@Crash--
Copy link
Copy Markdown
Contributor

Crash-- commented Nov 6, 2025

Oh, for Clisk connector maybe?

@zatteo
Copy link
Copy Markdown
Member Author

zatteo commented Nov 12, 2025

Oh, for Clisk connector maybe?

All usage of Crypto WebView

  • the onboarding process (see this commit) => this may not be necessary anymore as you said 👍
  • initialisation of the local httpServer (to limit access to routes by cozy-apps, see this commit)
  • to allow apps served over HTTP (non-secure) to access cryptography methods (see this PR)
    • on cozy-settings to enable or disable 2FA
    • on all apps that use cozy-keys-lib (= Harvest)

@Crash--
Copy link
Copy Markdown
Contributor

Crash-- commented Nov 20, 2025

on cozy-settings to enable or disable 2FA

We don't allow that anymore for new / migrated account.

initialisation of the local httpServer (to limit access to routes by cozy-apps, see this commit)

We can do without this kind of crypto.

And once we'll be able to load html file from http://localhost/file.html instead of getting the htmlContent and inject it (and with the dataproxy, we should be able to achieve this, we should take one or two hours together to test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants