fix: Avoid insert empty api key when creating openrag assistant 🐛#1674
fix: Avoid insert empty api key when creating openrag assistant 🐛#1674
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughReplaces inline assistantData shapes with a new exported Assistant type (adds required providerId, makes icon and apiKey optional). Introduces ASSISTANT_DOCTYPE, ACCOUNT_DOCTYPE, and OPENRAG model constant. createAssistant validates apiKey for non‑OPENRAG models, creates account documents with data/auth fields, embeds providerId in provider metadata, and cleans up created account on error. editAssistant merges and updates provider and account fields (login/model, baseUrl, apiKey) and removes baseUrl/password for OPENRAG. JSDoc and docs updated; JS function names unchanged, TypeScript signatures now use Assistant. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/cozy-client/src/models/assistant.js`:
- Around line 23-25: The current check uses !assistantData.apiKey which accepts
whitespace-only strings; normalize assistantData.apiKey (e.g., trim it) before
validating and before assigning so whitespace-only keys are rejected for
non-'openrag' models — update the validation that currently does if
(!assistantData.apiKey && assistantData.model !== 'openrag') to use a trimmed
value (reference assistantData.apiKey and assistantData.model) and ensure the
assignment later (the code around Line 37 that assigns the API key) stores the
normalized (trimmed) key instead of the raw input.
- Around line 23-25: Update the JSDoc for the assistantData parameter in this
module to mark assistantData.apiKey as optional/conditional: state that apiKey
is required for all models except when assistantData.model === 'openrag' (in
which case apiKey may be omitted). Edit the JSDoc block that documents the
assistantData shape (referencing assistantData, assistantData.apiKey and
assistantData.model) to explicitly describe the model-specific rule and then
re-generate the docs so the docs/api/* MD files reflect the change.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/api/cozy-client/modules/models.assistant.mdpackages/cozy-client/src/models/assistant.js
| if (!assistantData.apiKey && assistantData.model !== 'openrag') { | ||
| throw new Error('API key is empty') | ||
| } |
There was a problem hiding this comment.
Reject whitespace-only API keys for non-openrag models.
!assistantData.apiKey at Line 23 allows values like ' ', which still end up as invalid credentials. Normalize before validating and before assigning at Line 37.
Proposed fix
- if (!assistantData.apiKey && assistantData.model !== 'openrag') {
+ const apiKey = assistantData.apiKey?.trim()
+ if (!apiKey && assistantData.model !== 'openrag') {
throw new Error('API key is empty')
}
@@
- if (assistantData.apiKey) {
- account.auth.password = assistantData.apiKey
+ if (apiKey) {
+ account.auth.password = apiKey
}Also applies to: 36-38
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cozy-client/src/models/assistant.js` around lines 23 - 25, The
current check uses !assistantData.apiKey which accepts whitespace-only strings;
normalize assistantData.apiKey (e.g., trim it) before validating and before
assigning so whitespace-only keys are rejected for non-'openrag' models — update
the validation that currently does if (!assistantData.apiKey &&
assistantData.model !== 'openrag') to use a trimmed value (reference
assistantData.apiKey and assistantData.model) and ensure the assignment later
(the code around Line 37 that assigns the API key) stores the normalized
(trimmed) key instead of the raw input.
Update the function contract to reflect conditional apiKey requirement.
Behavior now allows missing apiKey for openrag, but current public docs still describe assistantData.apiKey as required. Please update the source JSDoc in this module to mark it conditional/optional and describe the model-specific rule.
Based on learnings: Documentation in docs/api//.md files is auto-generated from source code JSDoc comments. Do not edit these Markdown files directly; instead update the relevant JSDoc in the source files and re-generate the docs so the Markdown reflects the changes.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cozy-client/src/models/assistant.js` around lines 23 - 25, Update
the JSDoc for the assistantData parameter in this module to mark
assistantData.apiKey as optional/conditional: state that apiKey is required for
all models except when assistantData.model === 'openrag' (in which case apiKey
may be omitted). Edit the JSDoc block that documents the assistantData shape
(referencing assistantData, assistantData.apiKey and assistantData.model) to
explicitly describe the model-specific rule and then re-generate the docs so the
docs/api/* MD files reflect the change.
There was a problem hiding this comment.
Agreeing with the documentation comment. But no need to worry if the user enters ' ' for me.
There was a problem hiding this comment.
@zatteo, thank you for the feedback! I understand and will respect your decision on the whitespace validation—I won't flag that in future reviews.
Looking forward to seeing the JSDoc documentation updated to reflect that apiKey is optional for the openrag model. 👍
✏️ Learnings added
Learnt from: zatteo
Repo: linagora/cozy-client PR: 1674
File: packages/cozy-client/src/models/assistant.js:23-25
Timestamp: 2026-03-02T07:46:53.007Z
Learning: In the cozy-client repository, specifically in `packages/cozy-client/src/models/assistant.js`, whitespace-only API keys do not need validation or trimming. The project accepts API keys as-is without normalizing whitespace.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
lethemanh
force-pushed
the
adjust-creating-assistant-function
branch
from
43fd538 to
eb9eef1
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/cozy-client/src/models/assistant.js (1)
152-167:⚠️ Potential issue | 🟠 MajorClear inherited provider fields when switching an existing assistant to
openrag.
accountstarts from...provider, so theopenragbranch only skips overwritingdataandpassword; it does not remove the old values. Editing a previously credential-based assistant toopenragwill resave the oldbaseUrl, and may keep the old API key on the account as well.💡 Suggested fix
const account = { ...provider, auth: { ...(provider.auth || {}), login: assistantData.model } } if (assistantData.model !== 'openrag') { account.data = { ...(provider.data || {}), baseUrl: assistantData.baseUrl } - } - if (assistantData.apiKey) { - account.auth.password = assistantData.apiKey + if (assistantData.apiKey) { + account.auth.password = assistantData.apiKey + } + } else { + delete account.data + delete account.auth.password }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cozy-client/src/models/assistant.js` around lines 152 - 167, The current construction of account by spreading ...provider preserves old provider fields when switching to 'openrag'; ensure that when assistantData.model === 'openrag' you explicitly clear credential-specific fields: remove or reset account.data (so old baseUrl isn't retained) and remove account.auth.password (so old API keys aren't kept). Concretely, after creating account from provider, add a branch that if assistantData.model === 'openrag' then set account.data = {} (or delete account.data) and delete account.auth.password; otherwise keep the existing logic that sets account.data.baseUrl and account.auth.password from assistantData.apiKey.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/cozy-client/src/models/assistant.js`:
- Around line 152-167: The current construction of account by spreading
...provider preserves old provider fields when switching to 'openrag'; ensure
that when assistantData.model === 'openrag' you explicitly clear
credential-specific fields: remove or reset account.data (so old baseUrl isn't
retained) and remove account.auth.password (so old API keys aren't kept).
Concretely, after creating account from provider, add a branch that if
assistantData.model === 'openrag' then set account.data = {} (or delete
account.data) and delete account.auth.password; otherwise keep the existing
logic that sets account.data.baseUrl and account.auth.password from
assistantData.apiKey.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a42c0590-c55c-4c11-b5b8-98ae3141a470
📒 Files selected for processing (2)
docs/api/cozy-client/modules/models.assistant.mdpackages/cozy-client/src/models/assistant.js
| _id: createdAccountId | ||
| }, | ||
| cozyMetadata: { | ||
| providerId: assistantData.providerId |
There was a problem hiding this comment.
It's not cozyMetadata but metadata : https://github.com/cozy/cozy-doctypes?tab=readme-ov-file#relationships-with-metadata
There was a problem hiding this comment.
Can you remind me what is providerId here? the name of the provider like openrag ?
There was a problem hiding this comment.
providerId is used to store selected provider in this screen, the id is defined in https://github.com/linagora/cozy-libs/blob/46d6951cb22a17ac26c3b00c28caf47d405d6683/packages/cozy-search/src/components/CreateAssistantSteps/providers.json
| relationships: { | ||
| provider: { | ||
| ...existedAssistantData.relationships.provider, | ||
| cozyMetadata: { |
There was a problem hiding this comment.
Same remark about metadata vs cozyMetadata
rezk2ll
left a comment
rezk2ll
left a comment
There was a problem hiding this comment.
createAssistant correctly rejects a missing API key for non-openrag models. editAssistant does not; it silently accepts a missing key and saves the account without a password.
If the intent is that edits without an apiKey keep the existing one, that's fine, but it should be explicit (e.g. a comment or a guard that only sets password when a new key is provided and the model requires one).
Right now it's ambiguous whether this is intentional or an oversight.
| isCustomModel: assistantData.isCustomModel, | ||
| relationships: { | ||
| provider: { | ||
| ...existedAssistantData.relationships.provider, |
There was a problem hiding this comment.
If a user switches an existing assistant from a credentialed model to openrag, the old baseUrl and auth.password survive on the account because nothing clears them. The if (model !== 'openrag') guard only prevents overwriting, it doesn't remove.
After the account construction block (~line 158), an else branch should explicitly delete account.data and account.auth.password to avoid leaking old credentials into the openrag account.
| @@ -14,22 +14,31 @@ import logger from '../logger' | |||
| * @param {string} assistantData.model - Model identifier | |||
| * @param {string} assistantData.baseUrl - Provider's base URL | |||
| * @param {string} assistantData.apiKey - API key for authentication | |||
There was a problem hiding this comment.
the apiKey is not required here i guess
| export const createAssistant = async (client, assistantData) => { | ||
| let createdAccountId = null | ||
| try { | ||
| if (!assistantData.apiKey && assistantData.model !== 'openrag') { |
There was a problem hiding this comment.
openrad appears 4 times across the two functions i would move it to named constant
lethemanh
force-pushed
the
adjust-creating-assistant-function
branch
from
eb9eef1 to
7dc1e0f
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
packages/cozy-client/src/models/assistant.js (1)
76-78: Use theACCOUNT_DOCTYPEconstant in cleanup.The cleanup block uses a hardcoded
'io.cozy.accounts'string while the rest of the function uses theACCOUNT_DOCTYPEconstant. This inconsistency could lead to subtle bugs if the doctype ever changes.Proposed fix
try { await client.stackClient - .collection('io.cozy.accounts') + .collection(ACCOUNT_DOCTYPE) .destroy({ _id: createdAccountId })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cozy-client/src/models/assistant.js` around lines 76 - 78, Replace the hardcoded doctype string in the cleanup call with the ACCOUNT_DOCTYPE constant: locate the call to client.stackClient.collection('io.cozy.accounts').destroy({ _id: createdAccountId }) and change it to use the ACCOUNT_DOCTYPE symbol so it matches the rest of the function and avoids divergence if the doctype changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/cozy-client/src/models/assistant.js`:
- Around line 185-195: The metadata on the provider relationship is being
replaced instead of merged; update the object construction that builds
relationships.provider.data so it preserves
existedAssistantData.relationships.provider.data.metadata and only
adds/overwrites providerId from assistantData (i.e., merge existing metadata
with the new providerId) when creating the assistant object (look for
assistantData, existedAssistantData and relationships.provider.data in this
file).
In `@packages/cozy-client/types/models/assistant.d.ts`:
- Around line 18-20: The type declaration for the editAssistant payload
currently requires apiKey but the implementation/JSDoc marks it optional; update
the assistant model type so the apiKey property is optional (make apiKey?:
string) in the editAssistant-related interface/type (the declaration that
contains baseUrl, providerId and apiKey) to match the JS JSDoc and runtime
behavior.
- Around line 8-9: The TypeScript type for the assistant model marks apiKey as
required but JSDoc in assistant.js indicates apiKey is optional; update the
declaration so apiKey is optional (make the property optional on the exported
assistant model/interface/type that currently lists apiKey and providerId) to
match the JSDoc and allow omitting apiKey for openrag models; leave providerId
as required. Ensure the change targets the symbol that currently declares
"apiKey: string; providerId: string;" so consumers compile correctly.
---
Nitpick comments:
In `@packages/cozy-client/src/models/assistant.js`:
- Around line 76-78: Replace the hardcoded doctype string in the cleanup call
with the ACCOUNT_DOCTYPE constant: locate the call to
client.stackClient.collection('io.cozy.accounts').destroy({ _id:
createdAccountId }) and change it to use the ACCOUNT_DOCTYPE symbol so it
matches the rest of the function and avoids divergence if the doctype changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 86f665a7-8b6a-447b-9e55-5ab8df3341bd
📒 Files selected for processing (3)
docs/api/cozy-client/modules/models.assistant.mdpackages/cozy-client/src/models/assistant.jspackages/cozy-client/types/models/assistant.d.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/api/cozy-client/modules/models.assistant.md
lethemanh
force-pushed
the
adjust-creating-assistant-function
branch
from
7dc1e0f to
24b5f2c
Compare
lethemanh
force-pushed
the
adjust-creating-assistant-function
branch
from
24b5f2c to
7d31bec
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/cozy-client/src/models/assistant.js (1)
80-82: Use theACCOUNT_DOCTYPEconstant for consistency.The cleanup logic hardcodes
'io.cozy.accounts'while the rest of the file uses theACCOUNT_DOCTYPEconstant defined at line 6.Proposed fix
try { await client.stackClient - .collection('io.cozy.accounts') + .collection(ACCOUNT_DOCTYPE) .destroy({ _id: createdAccountId })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cozy-client/src/models/assistant.js` around lines 80 - 82, Replace the hardcoded doctype string in the cleanup call with the existing constant: use ACCOUNT_DOCTYPE instead of 'io.cozy.accounts' where the code calls client.stackClient.collection(...).destroy({ _id: createdAccountId }); update the collection invocation so it references ACCOUNT_DOCTYPE to keep consistency with other usages in this module.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/cozy-client/src/models/assistant.js`:
- Line 129: Update the JSDoc comment for the parameter in
packages/cozy-client/src/models/assistant.js by correcting the typo in the
`@param` description: change "editted" to "edited" for the {Assistant}
assistantData parameter so generated API docs use the correct spelling.
---
Nitpick comments:
In `@packages/cozy-client/src/models/assistant.js`:
- Around line 80-82: Replace the hardcoded doctype string in the cleanup call
with the existing constant: use ACCOUNT_DOCTYPE instead of 'io.cozy.accounts'
where the code calls client.stackClient.collection(...).destroy({ _id:
createdAccountId }); update the collection invocation so it references
ACCOUNT_DOCTYPE to keep consistency with other usages in this module.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b80cefde-f800-40e5-8e2c-06c3a9d96018
📒 Files selected for processing (4)
docs/api/cozy-client/interfaces/models.assistant.Assistant.mddocs/api/cozy-client/modules/models.assistant.mdpackages/cozy-client/src/models/assistant.jspackages/cozy-client/types/models/assistant.d.ts
| * @param {string} assistantData.model - Model identifier | ||
| * @param {string} assistantData.baseUrl - Provider's base URL | ||
| * @param {string} [assistantData.apiKey] - API key for authentication | ||
| * @param {Assistant} assistantData - Data for the editted assistant |
There was a problem hiding this comment.
Fix typo: "editted" → "edited".
This typo will propagate to the auto-generated API documentation.
Proposed fix
- * `@param` {Assistant} assistantData - Data for the editted assistant
+ * `@param` {Assistant} assistantData - Data for the edited assistant📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * @param {Assistant} assistantData - Data for the editted assistant | |
| * `@param` {Assistant} assistantData - Data for the edited assistant |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/cozy-client/src/models/assistant.js` at line 129, Update the JSDoc
comment for the parameter in packages/cozy-client/src/models/assistant.js by
correcting the typo in the `@param` description: change "editted" to "edited" for
the {Assistant} assistantData parameter so generated API docs use the correct
spelling.
7d31bec to
4286722
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
packages/cozy-client/src/models/assistant.js (2)
9-19: Consider makingbaseUrloptional for consistency withopenragmodel.The typedef marks
baseUrlas required, but foropenragmodels,baseUrlis not used (lines 42-46 skip setting it, and lines 168-169 delete it). This could confuse consumers who must provide abaseUrleven when it's ignored.Proposed fix
* `@property` {string} model - Model identifier - * `@property` {string} baseUrl - Provider's base URL + * `@property` {string} [baseUrl] - Provider's base URL (not used for openrag model) * `@property` {string} [apiKey] - API key for authentication🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cozy-client/src/models/assistant.js` around lines 9 - 19, The Assistant typedef incorrectly marks baseUrl as required; make baseUrl optional in the Assistant typedef so it matches openrag handling (update the JSDoc property to "[baseUrl] - Provider's base URL"). Also ensure code paths that set or delete baseUrl (references around the openrag handling logic and anywhere Assistant objects are constructed/validated) accept its absence without forcing a value—adjust constructors/validators that assume assistant.baseUrl exists (e.g., places where baseUrl is added or deleted) to treat it as optional.
168-171: Potential issue withdeleteand optional chaining.Using
delete account.data?.baseUrlmay not behave as expected. Ifaccount.dataisundefined, the expression evaluates toundefinedrather than performing a deletion. Sinceaccount.datais explicitly set at line 158-161, this should work here, but the pattern is misleading and can fail silently in edge cases.Safer approach
if (assistantData.model === OPENRAG_MODEL) { - delete account.data?.baseUrl - delete account.auth?.password + if (account.data) { + delete account.data.baseUrl + } + if (account.auth) { + delete account.auth.password + } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cozy-client/src/models/assistant.js` around lines 168 - 171, The current use of optional chaining with delete (in the block checking assistantData.model === OPENRAG_MODEL) is misleading and can be a no-op if account.data or account.auth are undefined; instead explicitly guard existence before deleting: check that account.data exists then delete account.data.baseUrl, and similarly check account.auth exists before deleting account.auth.password, so replace the optional-chained deletes with conditional checks around account.data and account.auth in the assistantData.model === OPENRAG_MODEL branch to ensure the properties are actually removed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/api/cozy-client/interfaces/models.assistant.Assistant.md`:
- Around line 33-41: The generated docs mark the assistant properties "icon" and
"apiKey" as required even though the source in
packages/cozy-client/src/models/assistant.js declares them optional ([icon],
[apiKey]); fix this by ensuring the doc generator recognizes optional props:
either add an explicit `@optional/`@optional true JSDoc tag to the icon and apiKey
declarations in models/assistant.js or update the docgen template/parser to
treat bracketed property names (e.g. [icon], [apiKey]) as optional and render
"Optional" in the generated docs for those fields.
- Around line 9-17: The generated docs mark apiKey as required but the source
JSDoc defines it as optional; fix by ensuring the JSDoc optional syntax is
emitted/handled: update the JSDoc for the Assistant model in
packages/cozy-client/src/models/assistant.js to use the explicit optional form
(e.g., `@property` {string} [apiKey]) if it isn’t already, then adjust the docs
generation config/template that produces
docs/api/cozy-client/interfaces/models.assistant.Assistant.md so optional
properties are rendered (showing brackets or “optional”); locate the Assistant
model and the apiKey property in models/assistant.js and update either the JSDoc
or the doc generator mapping/template to output the optional marker for apiKey
and re-run the doc generation.
- Line 17: Update the source repo path used by the docs generator and any JSDoc
source links so generated files under docs/api/cozy-client/ point to
linagora/cozy-client instead of github.com/cozy/cozy-client: adjust the docs
generator configuration (where repository or baseUrl is defined) and/or update
JSDoc `@see/`@link tags in files under packages/cozy-client/src/ (for example
packages/cozy-client/src/models/assistant.js) to use the linagora path; also fix
hardcoded links in manual docs (edit docs/architecture.md,
docs/relationships.md, docs/hooks.md, docs/mobile-guide.md) to replace
github.com/cozy/cozy-client with github.com/linagora/cozy-client so all
references are consistent.
---
Nitpick comments:
In `@packages/cozy-client/src/models/assistant.js`:
- Around line 9-19: The Assistant typedef incorrectly marks baseUrl as required;
make baseUrl optional in the Assistant typedef so it matches openrag handling
(update the JSDoc property to "[baseUrl] - Provider's base URL"). Also ensure
code paths that set or delete baseUrl (references around the openrag handling
logic and anywhere Assistant objects are constructed/validated) accept its
absence without forcing a value—adjust constructors/validators that assume
assistant.baseUrl exists (e.g., places where baseUrl is added or deleted) to
treat it as optional.
- Around line 168-171: The current use of optional chaining with delete (in the
block checking assistantData.model === OPENRAG_MODEL) is misleading and can be a
no-op if account.data or account.auth are undefined; instead explicitly guard
existence before deleting: check that account.data exists then delete
account.data.baseUrl, and similarly check account.auth exists before deleting
account.auth.password, so replace the optional-chained deletes with conditional
checks around account.data and account.auth in the assistantData.model ===
OPENRAG_MODEL branch to ensure the properties are actually removed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8b5216b1-eedd-4e7d-8e85-cc676a265b0a
📒 Files selected for processing (4)
docs/api/cozy-client/interfaces/models.assistant.Assistant.mddocs/api/cozy-client/modules/models.assistant.mdpackages/cozy-client/src/models/assistant.jspackages/cozy-client/types/models/assistant.d.ts
lethemanh
force-pushed
the
adjust-creating-assistant-function
branch
2 times, most recently
from
b03bbcb to
175d2a7
Compare
| login: assistantData.model | ||
| } | ||
| } | ||
| if (assistantData.model !== OPENRAG_MODEL) { |
There was a problem hiding this comment.
Like for apiKey, I don' think we should rely on the OPENRAG_MODEL magic const, but simply check whether or not the baseUrl is provided. So it's assistant's job to provide the baseUrl or not, depending on if we use openrag or not
| data: { | ||
| login: assistantData.model | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you also add the providerId ? Like this:
account.account_type = providerId
So we can identify which account it is
See https://github.com/cozy/cozy-doctypes/blob/master/docs/io.cozy.accounts.md
(the "konnector" concept does not apply here)
| export const createAssistant = async (client, assistantData) => { | ||
| let createdAccountId = null | ||
| try { | ||
| if (!assistantData.apiKey && assistantData.model !== OPENRAG_MODEL) { |
There was a problem hiding this comment.
I think we should not bother about OPENRAG_MODEL here, it's the client responsibility to provide the correct data and know the logic behind OPENRAG_MODEL (no apiKey, no baseUrl required)
lethemanh
force-pushed
the
adjust-creating-assistant-function
branch
from
175d2a7 to
5833cdf
Compare
| prompt: assistantData.prompt, | ||
| icon: assistantData.icon || null, | ||
| isCustomModel: assistantData.isCustomModel | ||
| isCustomModel: assistantData.isCustomModel, |
There was a problem hiding this comment.
I think this one is not required anymore, right? It is determined by the value of providerId
lethemanh
force-pushed
the
adjust-creating-assistant-function
branch
from
5833cdf to
17450ed
Compare
4 participants
Related to:
linagora/cozy-libs#2938
Summary by CodeRabbit
Enhancements
Bug Fixes
Documentation