Skip to content

feat: Force _rev for queries with .select fields #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paultranvan merged 1 commit into from
Aug 20, 2024
Merged

feat: Force _rev for queries with .select fields #1517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cozy-stack-client/src/DocumentCollection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,8 +532,8 @@ The returned documents are paginated by the stack.
return {
selector: mergedSelector,
use_index: indexName,
// TODO: type and class should not be necessary, it's just a temp fix for a stack bug
fields: fields ? [...fields, '_id', '_type', 'class'] : undefined,
// _id is necessary for the store, and _rev is required for offline. See https://github.com/cozy/cozy-client/blob/95978d39546023920b0c01d689fed5dd41577a02/packages/cozy-client/src/CozyClient.js#L1153
fields: fields ? [...fields, '_id', '_rev'] : undefined,
limit,
skip,
bookmark: options.bookmark || bookmark,
Expand Down
8 changes: 8 additions & 0 deletions packages/cozy-stack-client/src/DocumentCollection.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1527,13 +1527,21 @@ describe('DocumentCollection', () => {
})
expect(opts.sort).toEqual([{ name: 'asc' }, { date: 'asc' }])
})

it('should raise warning when there is a selector and no indexFields', () => {
collection.toMangoOptions({ name: 'toto' }, {})
expect(warnSpy).toHaveBeenCalled()
})

it('should not raise warning when there is a selector and indexFields', () => {
collection.toMangoOptions({ name: 'toto' }, { indexedFields: ['name'] })
expect(warnSpy).not.toHaveBeenCalled()
})

it('should add mandatory attributes when specifying fields', () => {
const fields = ['date']
const opts = collection.toMangoOptions({}, { fields })
expect(opts.fields).toEqual(['date', '_id', '_rev'])
})
})
})