Skip to content

fix: Fix jsdocs in queryAll#1333

Open
LucsT wants to merge 1 commit intomasterfrom
fix/cozyClientJsDoc
Open

fix: Fix jsdocs in queryAll#1333
LucsT wants to merge 1 commit intomasterfrom
fix/cozyClientJsDoc

Conversation

@LucsT
Copy link
Copy Markdown

@LucsT LucsT commented Mar 17, 2023

The jsdoc concerning queryAll wasn't showing the correct return (Array of docs)

I propose this correction.
What do you think ?

@LucsT LucsT force-pushed the fix/cozyClientJsDoc branch from ef83ad0 to cd44d0f Compare March 17, 2023 17:26
Copy link
Copy Markdown
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer QueryResult[] since CozyClientDocument[]` is about document, not JSON API related return.

There is a lot of work done in this #1234 in order to try to fix types issue.

@LucsT
Copy link
Copy Markdown
Author

LucsT commented Mar 20, 2023

@Crash--
Ok so you want me to add a commit in this PR instead with @returns {Promise<QueryResult[]>}
and close this one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants