Various fixes and improvements and fixes mostly for nemo #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeronymous
reviewed
Jun 10, 2025
Comment on lines
412
to
417
| self.device = self.device if self.device else 0 | ||
| if self.device == "cuda" or self.device == "gpu": | ||
| self.device = 0 | ||
| if self.device != "cpu": | ||
| get_num_gpus() | ||
| self.device = ALL_GPU_INDICES[self.device] |
Member
There was a problem hiding this comment.
This part is weird.
You don't check that self.device is an index, in the correct range (from the output of get_num_gpus)
Member
Author
There was a problem hiding this comment.
It will throw an error if it is not in the correct range since it will be out of range for ALL_GPU_INDICES which is set by calling get_num_gpus()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.