Skip to content

Conversation

@lijunchen
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 13, 2026 14:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the compiler pipeline and constructor resolution logic to improve code organization and maintainability.

Changes:

  • Restructured the pipeline module by splitting pipeline.rs into a module directory with mod.rs and pipeline.rs
  • Moved constructor resolution from AST-level promotion to FIR-level resolution with proper indexing
  • Extracted common code for building constructor paths from IDs

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/compiler/src/pipeline/mod.rs New module file exposing pipeline submodules and utilities
crates/compiler/src/pipeline/pipeline.rs Main pipeline logic moved from root pipeline.rs, removed AST-level constructor promotion
crates/compiler/src/pipeline/packages.rs Updated imports and added file sorting for determinism
crates/compiler/src/typer/name_resolution.rs Added ConstructorIndex and FIR-level constructor resolution logic
crates/compiler/src/typer/check.rs Extracted constructor path building into reusable method
crates/compiler/src/fir.rs Added def_paths tracking and new lower_to_fir_files_with_env function
crates/compiler/src/typer/toplevel.rs Formatting improvements for method chaining
crates/compiler/src/tests/*.rs Updated imports to use new pipeline module structure
crates/compiler/src/query.rs Updated imports to use new pipeline module structure
crates/compiler/src/main.rs Updated imports to use new pipeline module structure
crates/compiler/src/builtins.rs Formatting improvement
crates/ast/src/lower.rs Formatting improvement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lijunchen lijunchen merged commit b1995d6 into main Jan 14, 2026
7 checks passed
@lijunchen lijunchen deleted the refactor branch January 14, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants