Open
Conversation
simonbru
requested changes
Apr 24, 2022
| ).lower() not in ("y", "yes"): | ||
| return | ||
|
|
||
| if "CHANGELOG.md" not in files_to_deploy(): |
Contributor
There was a problem hiding this comment.
Suggested change
| if "CHANGELOG.md" not in files_to_deploy(): | |
| if "CHANGELOG.md" not in files_to_deploy(c): |
| # Changelog gen # | ||
| ################# | ||
|
|
||
| CHANGELOG_MD_PATH = os.path.join(BASE_DIR, "CHANGELOG.md") |
Contributor
There was a problem hiding this comment.
Should we also expose a changelog view in the project template ? Or do you think that this is a project-specific decision ?
|
|
||
| Before deploying, you should update the CHANGELOG.md file with the latest changes by running: | ||
| ``` | ||
| docker-compose exec backend fab <environment> generate_changelog |
Contributor
There was a problem hiding this comment.
Suggested change
| docker-compose exec backend fab <environment> generate_changelog | |
| docker-compose exec backend fab <environment> generate-changelog |
|
|
||
| @task | ||
| @remote | ||
| def generate_changelog(c, ignorecheck="n", initialize="n", **kwargs): |
Contributor
There was a problem hiding this comment.
Use booleans for these arguments ?
def generate_changelog(c, ignorecheck=False, initialize=False, **kwargs):
| def jira_release(c, command, **kwargs): | ||
| full_kwargs = dict() | ||
|
|
||
| if c.config["environment"] == "prod": |
Contributor
There was a problem hiding this comment.
Move this condition into comment_and_close_on_jira ? Otherwise it always overrides the command argument
| "generate_changelog", | ||
| **{ | ||
| "jira-prefix": jira_prefix, | ||
| "environment": c.config.environment, |
Contributor
There was a problem hiding this comment.
environment is not an argument of jira_release generate_changelog
simonbru
reviewed
Apr 24, 2022
| print_commits(get_outgoing_commits(c)) | ||
|
|
||
|
|
||
| @task |
Contributor
There was a problem hiding this comment.
Currently, it does not make sense as a task because it does not output anything to the console
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.