Merged
Conversation
feat: Don't use six, now we only support Python 3
feat: Update templates for CKAN 2.11
Feat/declare config options
…ick-interface feat: Update cli commands to use click
Copied from ckanext-harvest's CLI commands that ultimately send emails. We use ckan.lib.base.render to render email contents as HTML, and this function requires a request context. All other kinds of emails we send are prompted by a request (e.g. clicking on a subscribe or management link) so the request context exists, but when we prompt email sending with a CLI command, we need to create this context beforehand. It looks a bit odd to use the 'test_request_context' method here, but Flask prefers that 'request_context' is only used when an actual request is handled and external code uses 'test_request_app'.
…quest-context-for-sending-notification-emails fix: Create Flask request context in CLI send_any_notifications command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.