Skip to content

Only include valid activity_types in default list #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bellisk merged 2 commits into from
Aug 6, 2025
Merged

Only include valid activity_types in default list #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fe1bf6
fix: Only include valid activity_types in default list
bellisk Jul 30, 2025
9fd69e6
Merge pull request #13 from opendata-swiss/chore/clean-up-activity-types
stefina Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ckanext/subscribe/notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,9 @@ def get_notifications_by_email(
notifications = defaultdict(lambda: defaultdict(list))

if not activity_types:
activity_types = ["new", "changed", "updated", "created"]
# Valid activity_types all begin with one of: new, changed, deleted, or follow.
# See ckanext.activity.logic.validators for the full list.
activity_types = ["new", "changed"]

for activity in activities:
for subscription in objects_subscribed_to[activity.object_id]:
Expand Down
Loading