Skip to content

Fix bug in SMTP with Python 3.7+ #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bellisk merged 2 commits into from
Jul 29, 2025
Merged

Fix bug in SMTP with Python 3.7+ #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f630c
fix: Pass in server address when creating SMTP connection
bellisk Jul 29, 2025
d958eb2
Merge pull request #12 from opendata-swiss/fix/handle-smtp-bug
bellisk Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ckanext/subscribe/mailer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ def _mail_recipient(

def _mail_payload(msg, mail_from, recipient_email):
# Send the email using Python's smtplib.
smtp_connection = smtplib.SMTP()
if "smtp.test_server" in config:
# If 'smtp.test_server' is configured we assume we're running tests,
# and don't use the smtp.server, starttls, user, password etc. options.
Expand All @@ -77,6 +76,8 @@ def _mail_payload(msg, mail_from, recipient_email):
smtp_user = config.get("smtp.user")
smtp_password = config.get("smtp.password")

smtp_connection = smtplib.SMTP(smtp_server)

try:
smtp_connection.connect(smtp_server)
except socket.error as e:
Expand Down
Loading