Skip to content

Conversation

@jeanmonod
Copy link
Member

No description provided.

@jeanmonod jeanmonod requested review from Copilot and dbu September 3, 2025 03:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the test environment by removing older PHP versions and PHPUnit configurations while adding support for newer PHP versions. The changes modernize the CI testing matrix to focus on currently supported PHP versions.

  • Removed support for PHP 7.1-7.3 and legacy testing configurations
  • Added support for PHP 8.1, 8.2, 8.4, and 8.5
  • Simplified PHPUnit configuration by removing coverage section

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
phpunit.xml.dist Removed coverage configuration section to simplify PHPUnit setup
.github/workflows/ci.yml Updated CI matrix to test newer PHP versions (8.1-8.5) and removed legacy versions (7.1-7.3)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah makes sense to do this. you should adjust composer.json as well to reflect the supported php versions.

and i would tag this as a new minor version, not a patch version. that allows to fix important bugs for the legacy version without too much effort.

@jeanmonod jeanmonod force-pushed the upgrade-test-versions branch from 858ff75 to ec6ea36 Compare September 3, 2025 07:23
@jeanmonod jeanmonod changed the title Upgrade the tests versions Upgrade the tests versions for PHP 8.4 and 8.5 Sep 3, 2025
@jeanmonod jeanmonod requested a review from dbu September 3, 2025 07:26
@jeanmonod
Copy link
Member Author

@dbu Done! Can you have a little look at the compser.json?

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@jeanmonod jeanmonod merged commit 8d22e5e into main Sep 3, 2025
13 of 14 checks passed
@dbu dbu deleted the upgrade-test-versions branch December 3, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants