Conversation
…etting/loading filter options
…some redundant filters
StephGit
reviewed
Jan 30, 2026
AMW_angular/io/src/app/deployments/deployment-filter/deployment-filter.component.ts
Outdated
Show resolved
Hide resolved
StephGit
reviewed
Jan 30, 2026
StephGit
reviewed
Jan 30, 2026
AMW_angular/io/src/app/deployments/deployment-filter/deployment-filter.component.html
Outdated
Show resolved
Hide resolved
StephGit
reviewed
Jan 30, 2026
AMW_angular/io/src/app/deployments/deployment-filter/deployment-filter.component.html
Outdated
Show resolved
Hide resolved
StephGit
requested changes
Jan 30, 2026
Contributor
StephGit
left a comment
StephGit
left a comment
There was a problem hiding this comment.
Nice work to create a deployment-filter component. Some minor improvements with use of input/output signals and typing.
…ased filter system - Add FilterType enum to replace string literals for better type safety - Introduce FilterValue union type and isDateTimeModel type guard - Migrate DeploymentFilterComponent to modern Angular signals (input/output) - Optimize getFilterType with computed Map lookup (O(1) vs O(n) performance)
yvespp
force-pushed
the
deploy_filter_refact
branch
from
f754fb9 to
5e42151
Compare
StephGit
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.