Upgrade Dagger to 2.59.1 and migrate to AGP 9#1425
Closed
lihenggui wants to merge 1 commit intonav3-migrationfrom
Closed
Upgrade Dagger to 2.59.1 and migrate to AGP 9#1425lihenggui wants to merge 1 commit intonav3-migrationfrom
lihenggui wants to merge 1 commit intonav3-migrationfrom
Conversation
- Bump AGP 9.0.0, Hilt 2.59.1, protobuf plugin 0.9.6, roborazzi 1.56.0 - Migrate convention plugins to AGP 9 new DSL - Convert datastore-proto to JVM library - Fix Compose BOM transitive propagation and JVM target alignment - Fix SearchViewModel @AssistedFactory parameter mismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommonExtension,localDevices, newLibraryExtension/TestExtensionimports, remove explicitkotlin-androidplugin)kotlin-metadata-jvmKSP dependency for Hilt + Kotlin 2.3.0 compatibilitycore:datastore-protofrom Android library to JVM libraryapi(platform(bom))for Compose BOM to fix transitive version propagationSearchViewModel@AssistedFactoryparameter mismatchTest plan
./gradlew assembleFossDebugbuilds successfully (all modules except pre-existing nav3-migration issues in app-compose)./gradlew testFossDebugUnitTestpasses./gradlew spotlessCheckpasses./gradlew dependencyGuardto regenerate baselines