Add support for ternary conditional expression in tail call optimization#91
Open
kiendang wants to merge 6 commits intolihaoyi:masterfrom
Open
Add support for ternary conditional expression in tail call optimization#91kiendang wants to merge 6 commits intolihaoyi:masterfrom
kiendang wants to merge 6 commits intolihaoyi:masterfrom
Conversation
Collaborator
|
@kiendang thanks for the contribution, can you please add a test for this?. |
Author
|
I already did? |
Author
|
Sorry please don't merge yet. It's not perfect. I'll update + add more tests soon. |
Reuse all existing tests for tco rewritten using ternary expressions
Author
|
@azazel75 I've finished. Please review when you have time. @tco
def tail_sum(x, acc=0):
return acc if len(x) == 0 else tail_sum(x[1:], acc + x[0])will now expand to return (acc if len(x) == 0 else (TCOType.CALL, tail_sum, [x[1:], acc + x[0]], {}))I also added support for non-return ternary expression in tail position and added more tests (basically all the existing tests for tco rewritten using ternary expression). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables tail call optimization for ternary conditional expression in return statement.
e.g