Fix issue #11#12
Open
pmlt wants to merge 1 commit intolihaoyi:masterfrom
pmlt:fix-issue-11-remove-proxy-actor
Open
Fix issue #11#12pmlt wants to merge 1 commit intolihaoyi:masterfrom pmlt:fix-issue-11-remove-proxy-actor
pmlt wants to merge 1 commit intolihaoyi:masterfrom
pmlt:fix-issue-11-remove-proxy-actor
Conversation
Owner
|
Thanks for the patch! One question: the style of having separate actors was monkeyed blindly from the spray HTTP stack. Does that stack suffer the same problem? Or does it work around it in another way? Just want to get some context around the issue. |
Author
|
Well, I haven't tested a pure Spray Can app to see if it exhibits the same problem, so maybe it does. But in principle, having a proxy actor isn't the problem itself; it's the fact that not all TCP event messages were proxied by the same actor. Technically, even with my patch SprayWebSockets still uses a proxy actor similar to Spray Can (namely SocketServerConnection) but at least now all TCP event messages go through that proxy actor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the proxy actor of WebsocketFrontend by overriding
HttpServerConnection instead in SocketListener.