v2.1.2 version locked aws ruby sdk gem#1
Merged
ls-michielrensen merged 4 commits intomasterfrom Dec 7, 2017
Merged
Conversation
ls-brentsmith
approved these changes
Dec 7, 2017
ls-brentsmith
left a comment
ls-brentsmith
left a comment
There was a problem hiding this comment.
LGTM both changes are necessary for functionality.
You might consider making the aws-sdk version a node attribute so you could upgrade to 3 later more easily.
Member
Author
|
@ls-brentsmith well the problem with using an attribute for that is that the code is not compatible with v3 of the SDK. See even if you would switch the version dynamically, it would still fail, hence the hard-coded version lock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~> 2(Fixes: Ohai plugin incompatible withaws-sdk-ruby> 2 JonathanSerafini/chef-cfn#4)