Skip to content

Conversation

@zhenlu
Copy link

@zhenlu zhenlu commented Nov 27, 2024

No description provided.

conradoplg and others added 22 commits October 2, 2024 14:26
Co-authored-by: Conrado Gouvea <conradoplg@gmail.com>
* Add missing `derive(Getters)` for `dkg::{round1, round2}`

* update CHANGELOG

---------

Co-authored-by: Conrado Gouvea <conradoplg@gmail.com>
Update Changelog and Version numbers for Release v2.0.0 (#755)
* Expose to_element() for GroupCommitment

* Update to_element() for GroupCommitment to pub(crate)

Co-authored-by: Conrado Gouvea <conrado@zfnd.org>
* modify frost-core traits to enable taproot compatibility

This commit contains changes to the frost-core crate which
allow ciphersuites to better customize how signatures are computed.
This will enable taproot support without requiring major changes
to existing frost ciphersuites.

Co-authored by @zebra-lucky and @mimoo

This work sponsored by dlcbtc.com and lightspark.com

* add frost-secp256k1-tr crate and ciphersuite

Co-authored by @zebra-lucky and @mimoo

This work sponsored by dlcbtc.com and lightspark.com

* test coverage for taproot crate

Co-authored by @zebra-lucky and @mimoo

This work sponsored by dlcbtc.com and lightspark.com

* clippy fixes

* tweak DKG output to avoid rogue taproot tweaks

* add interoperability tests

* cleanup taproot implementation to minimize impact in frost_core

* Update PoK test vector to use nonce which generates an even-parity point

Uses r = e99ae2676eab512a3572c7b7655d633642a717250af57a7e0ccd5f9618b69f3f

* BIP341 key package tweaks shouldn't cause key negation

* prune the Context type, instead negate signature.R before verifying

With a couple of small adjustments to the code, we can remove the
need for this extra associated type on the Ciphersuite crate. Accepting
signature with odd-parity nonce values is OK, because BIP340 discard
the nonce parity bit anyway.

* proper TapTweak point-addition operates on even internal key representation

Thanks to @conradoplg for spotting this. The internal key is supposed
to be represented as an even-parity point when adding the TapTweak
point t*G. I added a regression test to ensure the tweaked verifying
key and its parity match the BIP341 spec.

* clippy test fixes

* fix no-std issues and warnings

---------

Co-authored-by: Conrado Gouvea <conradoplg@gmail.com>
* Update dkg.md

* Update dkg.md

* Update dkg.md
…#739)

Bumps [reviewdog/action-actionlint](https://github.com/reviewdog/action-actionlint) from 1.54.0 to 1.57.0.
- [Release notes](https://github.com/reviewdog/action-actionlint/releases)
- [Commits](reviewdog/action-actionlint@v1.54.0...v1.57.0)

---
updated-dependencies:
- dependency-name: reviewdog/action-actionlint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.7...v4.2.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [thiserror](https://github.com/dtolnay/thiserror) to permit the latest version.
- [Release notes](https://github.com/dtolnay/thiserror/releases)
- [Commits](dtolnay/thiserror@1.0.29...2.0.3)

---
updated-dependencies:
- dependency-name: thiserror
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fix Typographical Error in "Importing and General Information" Section
* secp256k1-tr: fix no-std support

* apply recent secp256k1 changes
@zhenlu zhenlu merged commit 6e87fcf into main Nov 27, 2024
15 of 16 checks passed
@zhenlu zhenlu deleted the newupstream branch November 27, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants