loopd: fix premature block height receipt from LND#1046
Merged
starius merged 5 commits intolightninglabs:masterfrom Nov 16, 2025
Merged
loopd: fix premature block height receipt from LND#1046starius merged 5 commits intolightninglabs:masterfrom
starius merged 5 commits intolightninglabs:masterfrom
Conversation
Make it easier to distinguish this error from a similar error few lines above.
Loop now guards all static-address managers against zero block heights: each constructor returns an error when invoked with a non-positive current height, and `loopd` validates the height from `GetInfo` before instantiating them. Tests and helper code were updated accordingly so we fail fast instead of registering chain notifications with invalid hints.
starius
force-pushed
the
wait-for-height
branch
from
8adf571 to
6d480cf
Compare
bhandras
approved these changes
Nov 16, 2025
hieblmi
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix errors like:
When loopd boots before lnd has reported a positive tip, the static address managers captured a zero initiation height and later passed it into
RegisterConfirmationsNtfn, triggering lnd'sErrNoHeightHint. The notifier recently started up later than the RPC server, so this race became visible in itest logs. This PR makes every static-address manager constructor reject zero heights, wires those errors throughloopdso we abort startup instead of running with invalid hints.Updated Go to 1.24.10 and lndclient to v0.20.0-6 to use BlockUntilChainNotifier from lightninglabs/lndclient#255
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes