Implement macaroon-permission-based client loading#37
Open
jalavosus wants to merge 1 commit intolightninglabs:masterfrom
Open
Implement macaroon-permission-based client loading#37jalavosus wants to merge 1 commit intolightninglabs:masterfrom
jalavosus wants to merge 1 commit intolightninglabs:masterfrom
Conversation
This commit changes core behavior of LndServices; instead of relying on macaroons for all rpc clients to be available, it instead checks the permissions of loaded macaroon files, and determines which clients can be loaded from there. If a read-only macaroon is not available for client compatibility checking, or admin permissions are not available for a Lightning client, the initialization function will return an error.
Author
|
This PR would work really nicely with the behavior implemented in #35, and would allow for more selective client usage. |
Author
|
I also acknowledge that this implementation is kinda messy, and any suggestions for cleaning it up are very much welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes core behavior of LndServices; instead of relying on
macaroons for all rpc clients to be available, it instead checks the
permissions of loaded macaroon files, and determines which clients can
be loaded from there.
If a read-only macaroon is not available for client compatibility
checking, or admin permissions are not available for a Lightning client,
the initialization function will return an error.
Pull Request Checklist
in
lnd_services.goare updated.