Skip to content

feeadjuster: add assert error messages #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daywalker90 merged 1 commit into from
Dec 15, 2025
Merged

feeadjuster: add assert error messages #768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions feeadjuster/feeadjuster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def get_config(plugin: Plugin, config: str):
and plugin.rpcversion[1] >= 8
):
result = plugin.rpc.listconfigs(config)["configs"]
assert len(result) > 0
assert len(result) > 0, "listconfigs returned no result"
conf_obj = result[config]
if "value_str" in conf_obj:
return conf_obj["value_str"]
Expand Down Expand Up @@ -152,7 +152,7 @@ def get_peerchannel(plugin: Plugin, scid: str):

def get_chan_fees(plugin: Plugin, scid: str):
channel = get_peerchannel(plugin, scid)
assert channel is not None
assert channel is not None, f"channel not found: {scid}"
return {
"base": channel["fee_base_msat"],
"ppm": channel["fee_proportional_millionths"],
Expand All @@ -169,7 +169,7 @@ def get_fees_median(plugin: Plugin, scid: str):
The assumption is that our node competes in fees to other peers of a peer.
"""
peer_id = get_peer_id_for_scid(plugin, scid)
assert peer_id is not None
assert peer_id is not None, f"peer_id not found for {scid}"
if plugin.listchannels_by_dst:
plugin.channels = plugin.rpc.call("listchannels", {"destination": peer_id})[
"channels"
Expand Down Expand Up @@ -280,7 +280,9 @@ def maybe_adjust_fees(plugin: Plugin, scids: list):
continue

percentage = get_adjusted_percentage(plugin, scid)
assert 0 <= percentage and percentage <= 1
assert 0 <= percentage and percentage <= 1, (
f"percentage is out of bounds: balances: {plugin.adj_balances[scid]} big_enough_liquidity: {int(plugin.big_enough_liquidity)}"
)
ratio = plugin.get_ratio(percentage)
if plugin.max_htlc_steps >= 1:
max_htlc = int(
Expand All @@ -304,7 +306,7 @@ def get_new_balance(plugin: Plugin, scid: str):
i = 0
while i < 5:
chan = get_peerchannel(plugin, scid)
assert chan is not None
assert chan is not None, f"channel not found: {scid}"
if scid not in plugin.adj_balances:
time.sleep(5)
plugin.peerchannels = get_peerchannels(plugin)
Expand Down Expand Up @@ -472,7 +474,7 @@ def init(options: dict, configuration: dict, plugin: Plugin, **kwargs):
plugin.log(
f"Plugin feeadjuster initialized "
f"({plugin.adj_basefee} base / {plugin.adj_ppmfee} ppm) with an "
f"imbalance of {int(100 * plugin.imbalance)}%/{int(100 * ( 1 - plugin.imbalance))}%, "
f"imbalance of {int(100 * plugin.imbalance)}%/{int(100 * (1 - plugin.imbalance))}%, "
f"update_threshold: {int(100 * plugin.update_threshold)}%, "
f"update_threshold_abs: {plugin.update_threshold_abs}, "
f"enough_liquidity: {plugin.big_enough_liquidity}, "
Expand Down
Loading