fix(widget): handle failed execution state with no failed actions#671
Merged
fix(widget): handle failed execution state with no failed actions#671
Conversation
|
Hey! This is your new endpoint: https://30757628.widget-fixfailnoa.pages.dev |
chybisov
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
https://linear.app/lifi-linear/issue/EMB-310/bug-execution-status-failed-but-no-action-marked-failed-on-reload
Why was it implemented this way?
Previously, the widget UI relied exclusively on action.status === 'FAILED' to show error states: the step card border, the inline error row, and the failure bottom sheet message. When no action carried the failed status, the UI appeared as if nothing went wrong — no red border, no error message, no "Try again" button context.
The fix takes a minimal approach: where no failed action exists but execution.status === 'FAILED', a synthetic action stub ({ status: 'FAILED', type: 'EXECUTION', error: step.execution?.error }) is used. This flows through the existing StepAction → useActionMessage → getErrorMessage pipeline unchanged, producing the appropriate error UI (or the "Unknown error" fallback when error is also absent). No new components or abstractions were introduced — just synthetic data fed into existing rendering paths.
Visual showcase (Screenshots or Videos)
Simulated execution failure with empty list of actions:
Screen.Recording.2026-03-16.at.18.44.39.mov
Checklist before requesting a review