fix: improve package exports and module resolution#668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why was it implemented this way?
Improves package compatibility for consumers by updating the export structure in
formatPackageJson.js:default→importin export conditions — makes the ESM intent explicit and improves resolution in bundlers that differentiate betweenimportandrequireconditionsmodulefield — provides a fallback entry point for older bundlers (e.g. Webpack 4) that don't support theexportsmaptypesVersions— ensures TypeScript can resolve subpath export types in projects usingmoduleResolution: "node"(not just"bundler"or"node16")./skeletonsubpath into the sharedallSubpathExportsso it's included intypesVersionsgenerationAlso includes the
4.0.0-alpha.3version bump across all packages.Checklist before requesting a review