-
Notifications
You must be signed in to change notification settings - Fork 98
feat: migrate build pipeline from tsc to tsdown #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # CLAUDE.md | ||
|
|
||
| ## Project | ||
| TypeScript monorepo (pnpm workspaces) with 5 packages under `packages/`: | ||
| - `@lifi/sdk` — core SDK (no external deps on other packages) | ||
| - `@lifi/sdk-provider-ethereum` — EVM provider (depends on sdk, uses viem) | ||
| - `@lifi/sdk-provider-solana` — Solana provider (depends on sdk, uses @solana/kit) | ||
| - `@lifi/sdk-provider-bitcoin` — Bitcoin provider (depends on sdk, uses bitcoinjs-lib) | ||
| - `@lifi/sdk-provider-sui` — Sui provider (depends on sdk, ESM-only, no CJS) | ||
|
|
||
| ## Build | ||
| - `pnpm build` — runs tsdown in all packages in parallel (no dependency ordering needed) | ||
| - `pnpm check` — biome lint/format | ||
| - `pnpm check:types` — tsc --noEmit (separate from build) | ||
| - Build outputs: `dist/esm/` (ESM + .d.ts), `dist/cjs/` (CJS only, not for sui) | ||
| - tsdown configs in each package root (`tsdown.config.ts`) | ||
| - `isolatedDeclarations: true` — all exports need explicit return type annotations | ||
|
|
||
| ## Testing & CI | ||
| - `pnpm test:unit` — vitest unit tests | ||
| - `pnpm pre-commit` — runs check + check:types + circular-deps + knip (via husky) | ||
| - `pnpm pre-push` — runs unit tests (via husky) | ||
|
|
||
| ## Code Style | ||
| - Biome for formatting and linting (`pnpm check:write` to auto-fix) | ||
| - No default exports in library code | ||
| - Import types with `import type` syntax | ||
|
|
||
| ## Known Issues | ||
| - `sdk-provider-ethereum/src/errors/parseEthereumErrors.ts` — pre-existing TS2339 error in check:types | ||
| - `sdk-provider-ethereum/src/utils/abi.ts` — parseAbi results typed as `Abi` (broader than inferred); downstream code uses `as` casts for readContract results | ||
|
|
||
| ## Release | ||
| - `pnpm release` → `pnpm release:publish` (uses lerna + standard-version) | ||
| - Pre-publish strips devDependencies via `scripts/prerelease.js`, restores via `scripts/postrelease.js` | ||
| - `scripts/version.js` inlines package name/version into `src/version.ts` at build time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| // helper function to convert full public key (33 bytes) to x-only compressed format (32 bytes) required after taproot update | ||
| export const toXOnly = (pubKey: Uint8Array) => | ||
| export const toXOnly = (pubKey: Uint8Array): Uint8Array => | ||
| pubKey.length === 32 ? pubKey : pubKey.subarray(1, 33) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| export const name = '@lifi/sdk-provider-bitcoin' | ||
| export const version = '4.0.0-beta.1' | ||
| export const version = '4.0.0-beta.2' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { defineConfig } from 'tsdown' | ||
|
|
||
| const entry = [ | ||
| 'src/**/*.ts', | ||
| '!src/**/*.spec.ts', | ||
| '!src/**/*.test.ts', | ||
| '!src/**/*.mock.ts', | ||
| '!src/**/*.handlers.ts', | ||
| ] | ||
|
|
||
| const shared = { | ||
| unbundle: true, | ||
| target: 'es2020' as const, | ||
| logLevel: 'warn' as const, | ||
| deps: { | ||
| skipNodeModulesBundle: true, | ||
| }, | ||
| } | ||
|
|
||
| export default defineConfig([ | ||
| { | ||
| ...shared, | ||
| entry, | ||
| outDir: 'dist/esm', | ||
| format: 'esm', | ||
| sourcemap: true, | ||
| dts: { sourcemap: true }, | ||
| outExtensions: () => ({ js: '.js', dts: '.d.ts' }), | ||
| }, | ||
| { | ||
| ...shared, | ||
| entry, | ||
| outDir: 'dist/cjs', | ||
| format: 'cjs', | ||
| sourcemap: true, | ||
| outExtensions: () => ({ js: '.js' }), | ||
| }, | ||
| ]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SDK provider packages rely on core SDK package - shouldn't we still build core SDK first, or it's handled anyhow differently now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since tsdown resolves workspace packages from source (not compiled output), all packages are built in a single parallel pass 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice