Draft
Conversation
5aaac66 to
2a625c7
Compare
975bb34 to
5157cec
Compare
Changes: - Add TronProvider with wallet integration, balance fetching, and address resolution - Add TronStepExecutor with sign, broadcast, and confirmation tasks - Add RPC retry with multi-URL fallback - Add Tron-specific error parsing for wallet and transaction errors - Add unit tests for error parsing, address resolution, and zero address utils - Register ChainType.TVM in SDK client storage
- Add TronCheckAllowanceTask and TronSetAllowanceTask for TRC-20 approval flow - Refactor TronSignAndExecuteTask to deserialize raw tx data from the API - Separate build, sign, and broadcast phases in approval to avoid re-signing on RPC retry - Add bandwidth error handling in parseTronErrors - Add stripHexPrefix utility and shared polling constants - Pass `from` address in TRC-20 balanceOf calls
- Use callTronRpcsWithRetry for broadcast in WaitForTransactionTask - Treat DUP_TRANSACTION_ERROR as success in both broadcast tasks - Remove unused getTronWebInstance - Add empty URLs guard in callTronRpcsWithRetry
5157cec to
e8ac163
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira task is linked to this PR?
https://linear.app/lifi-linear/issue/EMB-178/add-support-for-tron-ecosystem
Why was it implemented this way?
Explain the reasoning behind the implementation. Were there alternative approaches? Why was this solution chosen?
Visual showcase (Screenshots or Videos)
If applicable, attach screenshots, GIFs, or videos to showcase the functionality, UI changes, or bug fixes.
Checklist before requesting a review