Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Removed

- **BREAKING:** Removed `lo tasks create-foundation-xml-import`. The Foundation XML task-service pipeline was removed ([FLE-346](https://lifeomic.atlassian.net/browse/FLE-346), [task-service#199](https://github.com/lifeomic/task-service/pull/199)). Use the GA4GH replacement flow.

## [13.9.0] - 2023-01-04

### Added
Expand Down
89 changes: 0 additions & 89 deletions lib/cmds/tasks_cmds/create-foundation-task.js

This file was deleted.

69 changes: 0 additions & 69 deletions test/unit/commands/task.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const cancel = proxyquire('../../../lib/cmds/tasks_cmds/cancel', mocks);
const retry = proxyquire('../../../lib/cmds/tasks_cmds/retry', mocks);
const list = proxyquire('../../../lib/cmds/tasks_cmds/list', mocks);
const create = proxyquire('../../../lib/cmds/tasks_cmds/create', mocks);
const createFoundationTask = proxyquire('../../../lib/cmds/tasks_cmds/create-foundation-task', mocks);
const createNantomicsTask = proxyquire('../../../lib/cmds/tasks_cmds/create-nantomics-task', mocks);
const createAshionTask = proxyquire('../../../lib/cmds/tasks_cmds/create-ashion-task', mocks);
const createNantBulkTask = proxyquire('../../../lib/cmds/tasks_cmds/create-nant-bulk-task', mocks);
Expand Down Expand Up @@ -88,74 +87,6 @@ test.serial.cb('The "tasks-create" command should create a task', t => {
.parse('create');
});

test.serial.cb('The "create-foundation-xml-import" command should create a foundation ingest task', t => {
const res = { data: {} };
postStub.onFirstCall().returns(res);
callback = () => {
t.is(postStub.callCount, 1);
t.is(postStub.getCall(0).args[1], '/v1/tasks/system/foundation-xml-import');
t.deepEqual(postStub.getCall(0).args[2], {
xmlFileId: 'c8ef7300-1373-4e51-8eb9-ff333600f6a5',
datasetId: 'db3e09e9-1ecd-4976-aa5e-70ac7ada0cc3',
reportFileId: '1234',
subjectId: '2a6dc73e-ed30-4387-94c1-0cd661da56d9',
sequenceName: 'test3',
testType: 'test1',
performerId: 'performer1',
indexedDate: '1999-01-01T00:00:00.000Z',
indexType: 'all',
reIngestFile: false,
bodySite: 'Colon',
bodySiteSystem: 'http://a.fancy.system.com',
bodySiteDisplay: 'body site notation',
sendFailedTo: 'failed@user.com'
});
t.is(printSpy.callCount, 1);
t.is(printSpy.getCall(0).args[0], res.data);
t.end();
};

yargs.command(createFoundationTask)
.parse('create-foundation-xml-import db3e09e9-1ecd-4976-aa5e-70ac7ada0cc3 -x c8ef7300-1373-4e51-8eb9-ff333600f6a5 ' +
'-r 1234 -s 2a6dc73e-ed30-4387-94c1-0cd661da56d9 -n test3 --test-type test1 --performer-id performer1 ' +
'--indexed-date "1999-01-01" --index-type all --body-site "Colon" --body-site-system "http://a.fancy.system.com" ' +
'--body-site-display "body site notation" --send-failed-to failed@user.com');
});

test.serial.cb('The "create-foundation-xml-import" accepts re-ingest-file as an optional boolean flag', t => {
const res = { data: {} };
postStub.onFirstCall().returns(res);
callback = () => {
t.is(postStub.callCount, 1);
t.is(postStub.getCall(0).args[1], '/v1/tasks/system/foundation-xml-import');
t.deepEqual(postStub.getCall(0).args[2], {
xmlFileId: 'c8ef7300-1373-4e51-8eb9-ff333600f6a5',
datasetId: 'db3e09e9-1ecd-4976-aa5e-70ac7ada0cc3',
reportFileId: '1234',
subjectId: '2a6dc73e-ed30-4387-94c1-0cd661da56d9',
sequenceName: 'test3',
testType: 'test1',
performerId: 'performer1',
indexedDate: '1999-01-01T00:00:00.000Z',
indexType: 'all',
reIngestFile: true,
bodySite: 'Colon',
bodySiteSystem: 'http://a.fancy.system.com',
bodySiteDisplay: 'body site notation',
sendFailedTo: undefined
});
t.is(printSpy.callCount, 1);
t.is(printSpy.getCall(0).args[0], res.data);
t.end();
};

yargs.command(createFoundationTask)
.parse('create-foundation-xml-import db3e09e9-1ecd-4976-aa5e-70ac7ada0cc3 -x c8ef7300-1373-4e51-8eb9-ff333600f6a5 ' +
'-r 1234 -s 2a6dc73e-ed30-4387-94c1-0cd661da56d9 -n test3 --test-type test1 --performer-id performer1 ' +
'--indexed-date "1999-01-01" --index-type all --re-ingest-file --body-site "Colon" ' +
'--body-site-system "http://a.fancy.system.com" --body-site-display "body site notation"');
});

test.serial.cb('The "create-ashion-import" command should create a ashion ingest task', t => {
const res = { data: {} };
postStub.onFirstCall().returns(res);
Expand Down
Loading