fix: address 10 code audit issues with validation and robustness#28
Open
fix: address 10 code audit issues with validation and robustness#28
Conversation
…ss improvements Fix MED-09 (wipe min/max), MED-24 (upload after disposal), MED-26 (EXR tile overflow), MED-27 (DPX dimension validation), MED-31 (TIFF IFD count), MED-32 (DPX scanline overflow), MED-44 (worker Transferable validation), MED-45 (LUT cache key), LOW-08 (EXR layer sync), LOW-16 (transform history float precision). Adds 97 regression tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Coverage Report
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 10 issues identified during code audit (Wave 1-3), each with proper fix, regression tests, and two rounds of expert review (domain + QA).
wipeX/wipeY) now enforcemin: 0, max: 1with NaN sanitization_disposedflag and pre/post-await checksMAX_TILES_PER_LEVEL(2^24) to prevent allocation bombs from malformed filesgetDPXInfo()— zero, oversized, and total pixel overflow checksrenderErrorlutSize,skinHueCenter,skinHueRange,skinProtectionMin)currentExrLayerfield viapropertyChangedlistener1e-6) to filter float-precision noise97 regression tests added across 11 test files. All 25,690+ tests pass. Zero type errors. Zero new lint errors.
Test plan
tsc --noEmit: cleaneslint: 0 new errors🤖 Generated with Claude Code