Conversation
A later commit will add another layer of nesting in this function, so inverting this to keep the nesting down a bit.
Note: Some code in this commit references removed variables to minimize the diff here, later commits fix this
…complicate things
|
Can you help me understand a use case for this? Sorry if this is offensive but the screenshots look bad. The whole point of a histogram style chart is for visual representation of relative values, and that utility is completely undermined by arranging the bars horizontally like this. |
Horizontal layouts have been an open feature request for a while, and uses for it are around personal preference or fitting better into a UI (for example, a wide, relatively short window like the last screenshot could fit neatly under a player's hotbars, where a tall window likely wouldn't). The broader grid layout is admittedly more niche, the only case I thought of is for seeing all players at once without an excessive vertical footprint in alliance raids or something like Baldesion Arsenal or CLL/Dalriada.
No offense taken. I agree that the horizontal growth of bars with the horizontal layout loses some visual clarity. In practice while using this the last few weeks, I've found it to be minor, though your mileage may vary. It didn't occur to me before your comment, but (an option for) vertical growth for the bar fill would help with this, right? |








For a while, there's been an ask for horizontal bar layouts (#82). This implements a more generalized version of that which should be able to handle any grid layout like 1x10, 10x1, 5x5, 3x8, and so on.
Summary of changes:
CalculateLayout) and use the calculated layout to place the barsDrawBarsused to take, this does some math up front to determine the column and row counts based on the user's configuration and the number of combatantsDrawBars, since grid layouts make it more complicated to decide what rounding to useThe diff of all of this taken together is confusing, so I've tried to make the commit history clear.