Add additional network provider types #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at least WNNC_NET_SMB is a common one
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
===========================================
- Coverage 32.19% 10.12% -22.08%
===========================================
Files 23 23
Lines 6411 6411
Branches 1554 1554
===========================================
- Hits 2064 649 -1415
- Misses 3714 5642 +1928
+ Partials 633 120 -513 ☔ View full report in Codecov by Sentry. |
Member
|
@janstarke thanks for the suggested changes, I'll have a look when time permits |
joachimmetz
force-pushed
the
main
branch
2 times, most recently
from
972259f to
00e03ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at least
WNNC_NET_SMBis a common one, as it used for links to files on network shares