Fix GameVM::GetVM(), GameVM::currentTime, GameVM::currentMenuModeTime #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please tell me your NexusMods account name, RunnerScrab, I want to send some DPs to you. If you prefer a private convo, my Discord ID is |
Contributor
Author
sam271828182. Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 8 bytes of padding before
BSTSmartPointer<BSScript::IVirtualMachine> implin GameVM will make GameVM::GetVM() work in Starfield v1.15.222, and it also seems to put currentTime and currentMenuModeTime at the correct offsets from GameVM's base.GameScript::Loggeris now also at the correct offset.The other values in GameVM "look" correct, as the ones which are supposed to be pointers seem to point to other things in memory under debugging. I think it is likely that the 8 bytes of offset may fix them also, but do not presently know how to verify all of them.