Skip to content

Replace deprecated upload-artifact@v3 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youw merged 2 commits into from
Feb 21, 2025
Merged

Replace deprecated upload-artifact@v3 #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54fcb0b
Replace deprecated upload-artifact@v3
Youw Feb 21, 2025
021c9b9
Fix typo in CTest argument
Youw Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
env:
# set_option known to fail on Github Actions
COMMON_CTEST_ARGS: ---no-compress-output --output-on-failure -E "^set_option$"
COMMON_CTEST_ARGS: --no-compress-output --output-on-failure -E "^set_option$"

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
run: ctest --output-junit test_static.xml ${{ env.COMMON_CTEST_ARGS }}
- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Test Results Ubuntu
path: |
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
run: ctest --output-junit test_static.xml ${{ env.COMMON_CTEST_ARGS }}
- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Test Results macOS
path: |
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
run: ctest --output-junit test_ninja_static.xml ${{ env.COMMON_CTEST_ARGS }}
- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Test Results MSVC
path: |
Expand Down Expand Up @@ -304,7 +304,7 @@ jobs:

steps:
- name: Download Artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: artifacts
- name: Publish Test Results
Expand Down