Feature flag for selecting dns service #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I guess the downside of using dns-sd is that it would require avahi or similar to be running? |
Member
Author
|
To be honest, I'm not too sure. This pr is just my implementation of a feature flag because libreelec needs it apparently. I'm not really sure of the difference between mdns and dns-sd, hopefully the OP can provide some insight? Cc @awiouy |
Collaborator
Member
Author
|
@awiouy can you build with feature |
Collaborator
|
Will do right away! |
Collaborator
|
Builds and runs! Thanks much! |
paulfariello
pushed a commit
to paulfariello/librespot
that referenced
this pull request
Sep 23, 2025
Feature flag for selecting dns service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for allowing one to use dns-sd instead of mdns with the
--features "dns-sd"compile time flag. Documentation needs to be added. Review and suggestions welcomed.