test: fix flaky interop tests - address already in use#3396
Open
dozyio wants to merge 4 commits intolibp2p:mainfrom
Open
test: fix flaky interop tests - address already in use#3396dozyio wants to merge 4 commits intolibp2p:mainfrom
dozyio wants to merge 4 commits intolibp2p:mainfrom
Conversation
tabcat
requested changes
Mar 4, 2026
Member
|
It would be nice to understand why this is happening and fix the root cause, rather than masking it with retries? |
Collaborator
Author
It due to the control port number being assigned ahead of time that clashes when tests are run... seems there is around a 6% chance that ports will clash. Looked at a few different ways to do it but I've updated the PR to use unix domain sockets on non-windows for control instead. Windows still uses TCP but pre-binds to a port to get an available number |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inerop tests were intermittently failing - primarily due to
bind: address already in use.Should hopefully fix some of the flaky tests from here #3387
Change checklist