Skip to content

fix: setMaxConnections uses func arg in comparison #3389

Merged
dozyio merged 3 commits intolibp2p:mainfrom
dozyio:fix/set-max-conns
Mar 2, 2026
Merged

fix: setMaxConnections uses func arg in comparison #3389
dozyio merged 3 commits intolibp2p:mainfrom
dozyio:fix/set-max-conns

Conversation

@dozyio
Copy link
Collaborator

@dozyio dozyio commented Mar 2, 2026

Description

Compare against the func arg before throwing

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@dozyio dozyio requested a review from a team as a code owner March 2, 2026 10:32
@dozyio dozyio changed the title fix: setMaxConnections uses func arg fix: setMaxConnections uses func arg in comparison Mar 2, 2026
@tabcat
Copy link
Collaborator

tabcat commented Mar 2, 2026

Let's add a test.

Copy link
Collaborator

@tabcat tabcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@dozyio dozyio merged commit 8f0e1b2 into libp2p:main Mar 2, 2026
49 of 50 checks passed
@tabcat tabcat mentioned this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants