Closed
Conversation
Changing from "/.well-known/libp2p" to "/.well-known/libp2p/protocols" will break the ability to communicate with existing servers deployed without upgrading them first. Since these servers are running in places not under our control, they will not be immediately upgradable. This means that libp2phttp needs to support both the old and the new values, or revert to using the old value. This PR reverts to using the old resource name, which was changed in #2757.
Collaborator
|
What do you think about supporting both versions for a release for a bit, and then removing the old version? |
Contributor
Author
I think it will be one of those things we will need to support for a very long time or forever. Hundreds of storage providers are using the old resource name, and it is very difficult to get SPs to upgrade. |
Collaborator
|
Closing in favor of #2798 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing from "/.well-known/libp2p" to "/.well-known/libp2p/protocols" will break the ability to communicate with existing servers deployed without upgrading them first. Since these servers are running in places not under our control, they will not be immediately upgradable. This means that libp2phttp needs to support both the old and the new values, or revert to using the old value.
This PR reverts to using the old resource name, which was changed in #2757.