Closed
Conversation
marten-seemann
requested changes
Aug 25, 2023
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
This doesn't preserve Git history. Do you want me to use my repo consolidation script to do that?
Collaborator
Author
|
I think this is simple enough that there isn't a ton to gain from the perspective of keeping history to help debug things. But if you want to run your script, you are welcome to do so. |
Contributor
Probably not, I'd still prefer to preserve history. I don't see a good reason not to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2438 Builds on gostream. I think it would be good to bring it in to the monorepo.